Skip to content

fix: small default data and empty state fixes #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benlife5 merged 2 commits into from
Feb 23, 2026
Merged

fix: small default data and empty state fixes #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a1447
small fixes
benlife5 Feb 20, 2026
eb92649
Merge branch 'main' into small-fixes-2
benlife5 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/visual-editor/src/components/footer/FooterLinksSlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const FooterLinksSlotInternal: PuckComponent<FooterLinksSlotProps> = (

return (
<div
className={`${
className={`${puck.isEditing ? "min-h-[30px]" : ""} ${
variant === "secondary"
? `gap-5 flex flex-col md:flex-row w-full ${secondaryItemsAlignment}`
: "w-full grid grid-cols-1 md:grid-cols-5 gap-6"
Expand Down
4 changes: 2 additions & 2 deletions packages/visual-editor/src/components/header/HeaderLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ const HeaderLinksComponent: PuckComponent<HeaderLinksProps> = ({
// Early return for empty state
if (validLinks.length + validAlwaysCollapsedLinks.length === 0) {
return puck.isEditing ? (
<nav className="h-5 min-w-[100px] opacity-20" />
<nav className="h-5 min-w-[100px] min-h-[30px] opacity-20" />
) : (
<></>
);
Expand All @@ -296,7 +296,7 @@ const HeaderLinksComponent: PuckComponent<HeaderLinksProps> = ({
<nav
aria-label={ariaLabel}
ref={navRef}
className={`flex md:gap-6 md:items-center ${justifyClass}`}
className={`flex md:gap-6 md:items-center ${justifyClass} ${puck.isEditing ? " min-w-[100px] min-h-[30px]" : ""}`}
>
{/* Hidden measure list for overflow math */}
<ul
Expand Down
1 change: 1 addition & 0 deletions packages/visual-editor/src/internal/utils/removeDuplicateActionBars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const removeDuplicateActionBars = (): void => {
pt("callToAction", "Call To Action"),
pt("components.secondaryHeader", "Secondary Header"),
pt("components.headerLinks", "Header Links"),
pt("components.footerSocialLinksSlot", "Social Links"),
];

targets.forEach((target) => {
Expand Down
1 change: 1 addition & 0 deletions packages/visual-editor/src/vite-plugin/defaultLayoutData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1975,6 +1975,7 @@ const mainDefaultLayout = {
bgColor: "bg-palette-primary-light",
textColor: "text-black",
},
showSectionHeading: true,
},
data: {
field: "",
Expand Down