Open
Conversation
added 2 commits
January 21, 2022 15:47
- support unicode for windows - fixed line wrapping - Improved drawing by removing curso
starseeker
added a commit
to starseeker/cpp-linenoise
that referenced
this pull request
Oct 29, 2024
This is an attempt at merging the changes from yhirose#32
Contributor
|
@yhirose What's the status of this PR? |
Owner
|
@starseeker sorry for the late reply. To be honest, I didn't take a look at it since the current version satisfies my projects. But you can benefit from this pull request, I would like you to review it for me. If it looks good to you, please let me know. Thanks! |
Contributor
|
@fwaheed02 If you're still available to discuss this PR, can you provide an example image or two showing the cursor hiding? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following fixes are made: