feat: CreateBranch should auto-resolve branch name to commit SHA#2
Merged
Merged
Conversation
GitHub's CreateRef API requires a full 40-char commit SHA, but users naturally pass branch names like 'main' or 'feature/xxx'. This change auto-detects whether the ref is a SHA or a branch name and resolves branch names to their latest commit SHA via ListCommits. Closes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1
GitHub's
CreateRefAPI requires a full 40-character commit SHA as therefparameter. However, users naturally pass branch names like"main"or"feature/xxx", which results in a 422 error.Changes
provider/util.go: AddedisCommitSHA()helper to detect 40-char hex SHA stringsprovider/github.go:CreateBranchnow auto-detects whetherrefis a SHA or branch name. If not a SHA, it resolves viaListCommits(ctx, owner, repo, {Branch: ref, PerPage: 1})transparentlyprovider/github_test.go: Updated existing test mock to handle commits resolution, addedTestGitHub_CreateBranch_WithSHAfor direct SHA pass-throughOther Platforms
No changes needed for GitLab, Gitea, Forgejo, Tencent Code — their APIs already accept branch names as refs natively.