Skip to content

Namespace copied theme assets#79

Open
samdark wants to merge 1 commit into
masterfrom
namespace-theme-assets
Open

Namespace copied theme assets#79
samdark wants to merge 1 commit into
masterfrom
namespace-theme-assets

Conversation

@samdark

@samdark samdark commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary

  • copy theme assets to assets/themes/<theme>/... to prevent installed themes from overwriting each other
  • keep assets/theme/... aliases for the first registered theme for backwards compatibility
  • add a () template helper and update the bundled minimal theme/docs to use it

Tests

  • make test -- --filter ThemeAssetCopierTest
  • make test -- --filter TemplateContextTest
  • make test -- --filter TemplateResolverTest
  • make test -- --filter EntryRendererTest
  • make test -- --filter NotFoundPageWriterTest
  • make psalm
  • make test
  • BENCH_FILTER=ThemeAssetCopierBench make bench

Copilot AI review requested due to automatic review settings June 13, 2026 10:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@samdark, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes and 55 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 805de43e-6659-481c-b685-1aed82895dfd

📥 Commits

Reviewing files that changed from the base of the PR and between 315ad8d and f7d6e11.

📒 Files selected for processing (19)
  • benchmarks/ThemeAssetCopierBench.php
  • docs/configuration.md
  • docs/engine.md
  • docs/templates.md
  • roadmap.md
  • src/Build/Asset.php
  • src/Build/EntryRenderer.php
  • src/Build/PageTemplateRenderer.php
  • src/Build/TemplateContext.php
  • src/Build/TemplateHelpers.php
  • src/Build/TemplateResolver.php
  • src/Build/ThemeAssetCopier.php
  • tests/Unit/Build/EntryRendererTest.php
  • tests/Unit/Build/NotFoundPageWriterTest.php
  • tests/Unit/Build/TemplateContextTest.php
  • tests/Unit/Build/TemplateResolverTest.php
  • tests/Unit/Build/ThemeAssetCopierTest.php
  • themes/minimal/partials/footer.php
  • themes/minimal/partials/head.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch namespace-theme-assets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants