Conversation
terabytesoftw
commented
Apr 15, 2023
terabytesoftw
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
…ticsearch into initial-commit-1
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
=========================================
Coverage ? 57.04%
Complexity ? 170
=========================================
Files ? 6
Lines ? 440
Branches ? 0
=========================================
Hits ? 251
Misses ? 189
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| "keywords": ["yii", "elasticsearch", "active-record", "search", "fulltext"], | ||
| "description": "Elasticsearch integration and ActiveRecord for the Yii framework", | ||
| "keywords": [ | ||
| "yii2", |
There was a problem hiding this comment.
| "yii2", | |
| "yii3", |
| "license": "BSD-3-Clause", | ||
| "support": { | ||
| "issues": "https://github.com/yiisoft/yii-elasticsearch/issues", | ||
| "issues": "https://github.com/yiisoft/yii2-elasticsearch/issues", |
| "ext-curl": "*", | ||
| "ext-json": "*", | ||
| "ext-mbstring": "*", | ||
| "paragonie/random_compat": ">=1", |
There was a problem hiding this comment.
I don't think we need the compat library. randon is properly supported in new versions of PHP.
| }, | ||
| "config": { | ||
| "allow-plugins": { | ||
| "yiisoft/yii2-composer": true |
| */ | ||
|
|
||
| namespace Yiisoft\Db\ElasticSearch; | ||
| namespace Yiisoft\Elasticsearch; |
There was a problem hiding this comment.
If package not depend from yiisoft/db, then need remove db- prefix.
| public function delete(string $index, string|null $type, string $id, array $options = []): mixed | ||
| { | ||
| return $this->db->head([$index, $type, $id]); | ||
| if ($this->db->getDslVersion() >= 7) { |
There was a problem hiding this comment.
Do we support DSL for versions < 7?
|
Also, there's https://github.com/elastic/elasticsearch-php. Are we sure we want our own implementation for Yii3? |
If you check the client, and compare it with the api of this library, this is by far much better. |
However, if you think it's better to use the php library, then let's drop this package, just like the db packages, which you think aren't worth porting. |
4 participants
