Fix #176: Remove unused ext-dom dependency#176
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
=========================================
Coverage 87.18% 87.18%
Complexity 225 225
=========================================
Files 19 19
Lines 710 710
=========================================
Hits 619 619
Misses 91 91 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes an unused runtime dependency on the PHP ext-dom extension, updates documented requirements accordingly, and adds a regression test to prevent reintroducing the dependency.
Changes:
- Remove
ext-domfromcomposer.jsonruntime requirements. - Update README requirements to no longer list the DOM extension.
- Add a PHPUnit regression test asserting
ext-domis not present in Composer runtime requirements.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
composer.json |
Drops ext-dom from runtime require. |
README.md |
Updates the “Requirements” section to match Composer requirements. |
tests/ComposerRequirementsTest.php |
Adds a test ensuring ext-dom is not reintroduced as a runtime requirement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vjik
reviewed
Jun 10, 2026
4efdaad to
66bfae1
Compare
66bfae1 to
eeb97cd
Compare
ext-dom dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext-domruntime requirement.