Preserve modification time of rotated log files in FileRotator.

.github/workflows/rector-cs.yml

@@ -1,7 +1,7 @@
 name: Rector + PHP CS Fixer
 
 on:
-  pull_request_target:
+  pull_request:
     paths:
       - 'config/**'
       - 'src/**'
@@ -12,7 +12,7 @@ on:
       - '.php-cs-fixer.dist.php'
 
 permissions:
-  contents: read
+  contents: write
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -21,8 +21,5 @@ concurrency:
 jobs:
   rector:
     uses: yiisoft/actions/.github/workflows/rector-cs.yml@master
-    secrets:
-      token: ${{ secrets.YIISOFT_GITHUB_TOKEN }}
     with:
-      repository: ${{ github.event.pull_request.head.repo.full_name }}
       php: '8.0'

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 3.1.1 under development
 
 - Enh #83: Explicitly import classes in "use" section (@mspirkov)
+- Bug #84: Preserve modification time of rotated log files in `FileRotator` (@terabytesoftw)
 
 ## 3.1.0 December 13, 2025
 

src/FileRotator.php

@@ -13,13 +13,15 @@
 use function fclose;
 use function feof;
 use function file_exists;
+use function filemtime;
 use function filesize;
 use function flock;
 use function fread;
 use function ftruncate;
 use function is_file;
 use function sprintf;
 use function substr;
+use function touch;
 use function unlink;
 
 use const LOCK_EX;
@@ -69,10 +71,10 @@
      * @param bool $compressRotatedFiles Whether to compress rotated files with gzip.
      */
     public function __construct(
         int $maxFileSize = 10240,
         int $maxFiles = 5,
         private ?int $fileMode = null,
         bool $compressRotatedFiles = false,
     ) {
         $this->checkCannotBeLowerThanOne($maxFileSize, '$maxFileSize');
         $this->checkCannotBeLowerThanOne($maxFiles, '$maxFiles');
@@ -80,7 +82,7 @@
         $this->maxFileSize = $maxFileSize;
         $this->maxFiles = $maxFiles;
 
         if ($compressRotatedFiles && !extension_loaded('zlib')) {
             throw new RuntimeException(sprintf(
                 'The %s requires the PHP extension "ext-zlib" to compress rotated files.',
                 self::class,
@@ -98,13 +100,13 @@
             $newFile = $file . '.' . ($i + 1);
 
             if ($i === $this->maxFiles) {
                 $this->safeRemove($this->compressRotatedFiles ? $rotateFile . self::COMPRESS_EXTENSION : $rotateFile);
                 continue;
             }
 
             if ($this->compressRotatedFiles && is_file($rotateFile . self::COMPRESS_EXTENSION)) {
                 $this->rotate($rotateFile . self::COMPRESS_EXTENSION, $newFile . self::COMPRESS_EXTENSION);
                 continue;
             }
 
             if (!is_file($rotateFile)) {
@@ -129,6 +131,8 @@
      */
     private function rotate(string $rotateFile, string $newFile): void
     {
+        $mTime = filemtime($rotateFile);
+
         copy($rotateFile, $newFile);
 
         if ($this->compressRotatedFiles && !$this->isCompressed($newFile)) {
@@ -139,6 +143,10 @@
         if ($this->fileMode !== null) {
             chmod($newFile, $this->fileMode);
         }
+
+        if ($mTime !== false) {
+            touch($newFile, $mTime);
+        }
     }
 
     /**

tests/FileRotatorTest.php

@@ -14,10 +14,13 @@
 use function clearstatcache;
 use function dirname;
 use function file_get_contents;
+use function filemtime;
 use function filesize;
 use function mkdir;
 use function range;
 use function str_repeat;
+use function time;
+use function touch;
 
 final class FileRotatorTest extends TestCase
 {
@@ -71,6 +74,34 @@ public function testRotate(bool $compress): void
         }
     }
 
+    /**
+     * @dataProvider rotateDataProvider
+     */
+    public function testRotatePreservesModificationTime(bool $compress): void
+    {
+        $rotator = new FileRotator(1, 2, null, $compress);
+        $logFile = $this->getLogFilePath();
+        $fileTarget = new FileTarget($logFile, $rotator);
+        $logger = new Logger([$fileTarget]);
+        $compressExtension = $compress ? '.gz' : '';
+
+        $logger->debug($this->generateKilobytesOfData(1));
+        $logger->flush(true);
+
+        $expectedTime = time() - 7200;
+        touch($logFile, $expectedTime);
+        clearstatcache();
+
+        $logger->debug('x');
+        $logger->flush(true);
+
+        clearstatcache();
+
+        $rotatedFile = "{$logFile}.1{$compressExtension}";
+        $this->assertFileExists($rotatedFile);
+        $this->assertSame($expectedTime, filemtime($rotatedFile));
+    }
+
     /**
      * @dataProvider rotateDataProvider
      */