Change QueueInterface::getChannel() result type to string only#239
Merged
Change QueueInterface::getChannel() result type to string only#239
QueueInterface::getChannel() result type to string only#239Conversation
Member
vjik
commented
Jan 27, 2025
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
============================================
+ Coverage 92.87% 93.09% +0.21%
Complexity 359 359
============================================
Files 47 47
Lines 969 970 +1
============================================
+ Hits 900 903 +3
+ Misses 69 67 -2 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Jan 28, 2025
Contributor
|
@vjik What's the purpose of channels without adapters? Before this change a channel is a configured adapter. |
Member
Author
Before this change queue also could be without adapter. See code in master branch. |
viktorprogger
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.