Make count-based OOM injection persistent after trigger count (based on b458678) - #10
Draft
yjyang62 wants to merge 4 commits into
Draft
Make count-based OOM injection persistent after trigger count (based on b458678)#10yjyang62 wants to merge 4 commits into
yjyang62 wants to merge 4 commits into
Conversation
Co-authored-by: yjyang62 <yjyang62@users.noreply.github.com>
Co-authored-by: yjyang62 <yjyang62@users.noreply.github.com>
Co-authored-by: yjyang62 <yjyang62@users.noreply.github.com>
Based on commit b458678. Once the configured trigger count is reached, op, allocator, and HCCL hooks keep throwing synthetic OOM on every subsequent operation. File-based triggers still honor the one-shot *_TRIGGER_MODE settings. Co-authored-by: yjyang62 <yjyang62@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
基于 commit
b458678，修改 op / allocator / HCCL 三处 OOM 注入逻辑：达到配置次数后，后续每次操作都持续抛出 OOM 故障。Changes
在
shouldThrowOpOom、shouldThrowAllocatorOom、shouldThrowHcclOom中，当count_triggered为 true 时直接返回 true，跳过一次性的*_TRIGGER_MODE限制：HCCL_OOM_COUNT/NPU_ALLOCATOR_OOM_TRIGGER_COUNT/HCCL_OOM_TRIGGER_COUNT后，持续注入 OOM*_TRIGGER_MODE控制，默认仍为一次性Behavior
always/repeat重复）Files
torch_npu/csrc/framework/OpCommand.cpptorch_npu/csrc/core/npu/NPUCachingAllocator.cpptorch_npu/csrc/distributed/ProcessGroupHCCL.cppdocs/oom_fault_injection.md