fix: cover HCCL OOM trigger at op api dispatch - #8
Draft
yjyang62 wants to merge 2 commits into
Draft
Conversation
Co-authored-by: yjyang62 <yjyang62@users.noreply.github.com>
Co-authored-by: yjyang62 <yjyang62@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
【合入来源】
【修改方案】
HCCL_OOM_TRIGGER_COUNT注入计数从ProcessGroupHCCL的 collective/p2p 模板层迁移到OpCommand::RunOpApiV3统一入口。Hccl*通信 API,覆盖 allgather、reduce_scatter、send/recv、alltoall、batch send/recv 等真实 HCCL op api 调用路径。current_count >= trigger_count时抛出OutOfMemoryError,避免原先只在单个计数窗口触发导致错过。hcclBroadcast改为RunOpApiV3("HcclBroadcast", ...),避免该路径绕过统一计数。【资料变更】
不涉及
【接口变更】
不涉及
【功能验证】
git diff --check HEAD~2 HEADrg确认HCCL_OOM_TRIGGER_COUNT注入逻辑仅保留在OpCommand::RunOpApiV3统一入口,并确认 fallbackHcclBroadcast也走RunOpApiV3。【CheckList】