Make HCCL OOM injection persistent after trigger count - #9
Draft
yjyang62 wants to merge 1 commit into
Draft
Conversation
Remove the upper bound (trigger_count + 2) so that injected HCCL OOM errors continue for all subsequent operations once the call count exceeds HCCL_OOM_TRIGGER_COUNT. Co-authored-by: yjyang62 <yjyang62@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
修改
maybeThrowHcclOom的触发条件：达到HCCL_OOM_TRIGGER_COUNT次数后，后续所有 HCCL 操作都会持续注入 OOM 故障，而不是仅在触发后的 2 次调用内注入。Changes
current_count > trigger_count && current_count < trigger_count + 2改为current_count > trigger_countOutOfMemoryErrorBehavior