Add 2kki locations: Map3151, 3158#241
Conversation
2kki/config.json
Outdated
| { "title": "Dazzling Garden", "coords": { "x1": 0, "y1": 0, "x2": 39, "y2": 15 } }, | ||
| { "title": "Waterworks", "coords": { "x1": 24, "y1": 76, "x2": 44, "y2": 89 } }, | ||
| { "title": "Red Desert Ruins", "coords": { "x1": 0, "y1": 72, "x2": 59, "y2": 74 } }, | ||
| { "title": "Red Desert Ruins", "coords": { "x1": 0, "y1": 76, "x2": 21, "y2": 89 } } |
There was a problem hiding this comment.
It's best to have one of the coordinates for a location to be set as an else, as-in, have it be displayed if the coordinates of the player is in none of those areas, like how it is done for all other coordinates set.
There was a problem hiding this comment.
Thank you. i will add it
| { "title": "Star Cubes World", "coords": { "x1": 0, "y1": 213, "x2": 99, "y2": 349 } }, | ||
| "Dazzling Garden" | ||
| ], | ||
| "3158": { |
There was a problem hiding this comment.
Was using the previous map argument necessary here? It should only be used in Yume 2kki if there is no other option, as any possibility of warping while on the same map (e.g. use of the Bat effect) will prevent it from working properly.
There was a problem hiding this comment.
Map3158 has 2 locations, "Cubic Cliffs" and "Painted Landscape", sharing the same map and coords, causing both to appear.
for bat issue, i believe fixing the location display error should take priority. how about it?
and using bat on this map causes 2kki-side issues, which have already been reported as bugs and should be resolved in the future.(Since bat is not intended for use here)
(additionally, regarding this point, there are other instances of else used in this config, and those will also be affected)
There was a problem hiding this comment.
That works in that case, as there is no other alternative and the map should not be affected post-fix ultimately.
About the other else cases in the Yume 2kki configs, they are all tied to similar cases, either due to reusing the same coords (e.g. Jigsaw Puzzle World menu, Bleak Future boy balcony which uses the same coordinates than the normal Bleak Future balcony), or to avoid bugs (e.g. the Mask Shop map is set with this argument, as while in the Deluxe Mask Shop, when buying a mask, the game quickly teleports you to the Mask Shop, which leads to a display bug otherwise, and this setting allows avoiding this problem altogether).
It may be possible that some of the cases in it use the argument while not needed, depending on who implemented it and why, but there shouldn't be a lot of them normally and aren't really important.
There was a problem hiding this comment.
Thank you for the explanation. Thats very helpful and thanks for the review as well!
2 participants
Add missing 2kki locations