-
Notifications
You must be signed in to change notification settings - Fork 68
Profiling: fix do_profile decorator
#1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MustafaJafar
wants to merge
4
commits into
develop
Choose a base branch
from
bugfix/1638-do_profile-doesnt-work-as-a-decorator-2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Profiling: fix do_profile decorator
#1663
MustafaJafar
wants to merge
4
commits into
develop
from
bugfix/1638-do_profile-doesnt-work-as-a-decorator-2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
iLLiCiTiT
reviewed
Jan 29, 2026
Comment on lines
+8
to
+42
| def do_profile(to_file=None): | ||
| """Wraps function in profiler run and print stat after it is done. | ||
|
|
||
| Args: | ||
| to_file (str, optional): If specified, dumps stats into the file | ||
| instead of printing. | ||
|
|
||
| """ | ||
|
|
||
| def _do_profile(fn): | ||
| @functools.wraps(fn) | ||
| def profiled(*args, **kwargs): | ||
| profiler = cProfile.Profile() | ||
| try: | ||
| profiler.enable() | ||
| res = fn(*args, **kwargs) | ||
| profiler.disable() | ||
| return res | ||
| finally: | ||
| if to_file: | ||
| profiler.dump_stats(to_file) | ||
| else: | ||
| profiler.print_stats() | ||
| return profiled | ||
|
|
||
| # If used as @do_profile, to_file is the function | ||
| if callable(to_file): | ||
| fn = to_file | ||
| to_file = None | ||
| return _do_profile(fn) | ||
|
|
||
| if to_file: | ||
| to_file = to_file.format(pid=os.getpid()) | ||
|
|
||
| def profiled(*args, **kwargs): | ||
| profiler = cProfile.Profile() | ||
| try: | ||
| profiler.enable() | ||
| res = fn(*args, **kwargs) | ||
| profiler.disable() | ||
| return res | ||
| finally: | ||
| if to_file: | ||
| profiler.dump_stats(to_file) | ||
| else: | ||
| profiler.print_stats() | ||
| return _do_profile |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually this is done using required kwargs, or it is one of the options.
Suggested change
| def do_profile(to_file=None): | |
| """Wraps function in profiler run and print stat after it is done. | |
| Args: | |
| to_file (str, optional): If specified, dumps stats into the file | |
| instead of printing. | |
| """ | |
| def _do_profile(fn): | |
| @functools.wraps(fn) | |
| def profiled(*args, **kwargs): | |
| profiler = cProfile.Profile() | |
| try: | |
| profiler.enable() | |
| res = fn(*args, **kwargs) | |
| profiler.disable() | |
| return res | |
| finally: | |
| if to_file: | |
| profiler.dump_stats(to_file) | |
| else: | |
| profiler.print_stats() | |
| return profiled | |
| # If used as @do_profile, to_file is the function | |
| if callable(to_file): | |
| fn = to_file | |
| to_file = None | |
| return _do_profile(fn) | |
| if to_file: | |
| to_file = to_file.format(pid=os.getpid()) | |
| def profiled(*args, **kwargs): | |
| profiler = cProfile.Profile() | |
| try: | |
| profiler.enable() | |
| res = fn(*args, **kwargs) | |
| profiler.disable() | |
| return res | |
| finally: | |
| if to_file: | |
| profiler.dump_stats(to_file) | |
| else: | |
| profiler.print_stats() | |
| return _do_profile | |
| def do_profile(*args, to_file=None): | |
| """Wraps function in profiler run and print stat after it is done. | |
| Args: | |
| to_file (str, optional): If specified, dumps stats into the file | |
| instead of printing. | |
| """ | |
| def _do_profile(fn): | |
| @functools.wraps(fn) | |
| def profiled(*args, **kwargs): | |
| profiler = cProfile.Profile() | |
| try: | |
| profiler.enable() | |
| res = fn(*args, **kwargs) | |
| profiler.disable() | |
| return res | |
| finally: | |
| if to_file: | |
| profiler.dump_stats(to_file) | |
| else: | |
| profiler.print_stats() | |
| return profiled | |
| if to_file: | |
| to_file = to_file.format(pid=os.getpid()) | |
| if args: | |
| return _do_profile(args[0]) | |
| return _do_profile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
do_profiledecoratorTesting notes:
In AYON console, running these cases should work: