Add the possibility to set a unit for the size of the stick#124
Open
erbizard wants to merge 5 commits intoyoannmoinet:masterfrom
Open
Add the possibility to set a unit for the size of the stick#124erbizard wants to merge 5 commits intoyoannmoinet:masterfrom
erbizard wants to merge 5 commits intoyoannmoinet:masterfrom
Conversation
Owner
|
Hi there, thanks for this.
Do you have an example somewhere I could check? |
Author
|
The problem is the "responsiveness" When you are forced to use px, you can't really make a stick with the same size on every platforms, if you want +-10% on as 1920 * 1080 the size is 190px, but when you test on a mobile 640*360 190 px is like quarter of the screen, so it can be problematic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've encountered a problem after using your lib on desktop / mobile.
The problem is the "px" size is not responsive at all so the stick doesn't react the same on all platforms.
I've changed the lib to add a unit / val in the size parameter to allow any unit on the size of the sticks.
The major problem of this update is, if you release this, you need to update major, cause old code with old size isn't supported. and with the typescript I can't make a retro-compatibility.
Regards,
Arthur Rouet