fix: non browser environment compatibility which breaks SSR compilation#226
Open
khelkun wants to merge 2 commits intoyoannmoinet:masterfrom
Open
fix: non browser environment compatibility which breaks SSR compilation#226khelkun wants to merge 2 commits intoyoannmoinet:masterfrom
khelkun wants to merge 2 commits intoyoannmoinet:masterfrom
Conversation
…d non-browser environments
…wser environments, and throw error if Manager.create is called in such environment
Owner
|
Thanks for the very well detailed PR, really appreciated. |
Owner
|
I'm wondering if we'd still have the issue with the massive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @yoannmoinet ,
To make the story as short as possible:
windowobject which only exists in a web browser environment.windowobject insuper.jsis accessed at the nipplejs module import, and also because on top of that the nipplejs library itself is built as umd but without definingglobalObjectin webpack config for the compatibility on non browser environments.For the record, the error is:
So this PR has 2 commits:
windowobject globally during thesuper.jsmodule importglobalObjectin non browser environment and throw an error if nipplejsManager.createis actually called from a non browser environment.If you could accept that and release a nipplejs version toward it, I'd be really grateful 🙏