Skip to content

TEST #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yoavf wants to merge 3 commits into from
Closed

TEST #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9993f03
Merge pull request #2 from yoavf/add/posthog
yoavf Nov 22, 2025
3ebe680
fix: prevent crash when navigating between metrics with different sce…
claude Nov 23, 2025
7510041
Merge pull request #3 from yoavf/claude/fix-metrics-navigation-crash-…
yoavf Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/components/MetricVisualizer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ const MetricVisualizer = ({ metric }) => {
const [healthyScenario, setHealthyScenario] = useState(null);
const [unhealthyScenario, setUnhealthyScenario] = useState(null);

// Early return if visualizations data is missing or malformed
if (!metric?.visualizations) {
return null;
}

// Determine if data has multiple scenarios
const healthyData = metric.visualizations.healthy;
const unhealthyData = metric.visualizations.unhealthy;
Expand All @@ -44,22 +49,32 @@ const MetricVisualizer = ({ metric }) => {
}
}, [metric, hasMultipleHealthy, hasMultipleUnhealthy]);

// Get current display data
// Get current display data with defensive checks for stale scenario state
let currentData, currentAnalysis;

if (mode === 'healthy') {
if (hasMultipleHealthy && healthyScenario) {
if (hasMultipleHealthy && healthyScenario && healthyData[healthyScenario]) {
currentData = healthyData[healthyScenario].data;
currentAnalysis = healthyData[healthyScenario].analysis;
} else {
} else if (hasMultipleHealthy) {
// Fallback to first scenario if current scenario is stale
const firstKey = Object.keys(healthyData)[0];
currentData = healthyData[firstKey]?.data;
currentAnalysis = healthyData[firstKey]?.analysis;
} else if (healthyData) {
currentData = healthyData.data;
currentAnalysis = healthyData.analysis;
}
} else {
if (hasMultipleUnhealthy && unhealthyScenario) {
if (hasMultipleUnhealthy && unhealthyScenario && unhealthyData[unhealthyScenario]) {
currentData = unhealthyData[unhealthyScenario].data;
currentAnalysis = unhealthyData[unhealthyScenario].analysis;
} else {
} else if (hasMultipleUnhealthy) {
// Fallback to first scenario if current scenario is stale
const firstKey = Object.keys(unhealthyData)[0];
currentData = unhealthyData[firstKey]?.data;
currentAnalysis = unhealthyData[firstKey]?.analysis;
} else if (unhealthyData) {
currentData = unhealthyData.data;
currentAnalysis = unhealthyData.analysis;
}
Expand Down