feat: support compilation with TruffleRuby#8
Merged
Conversation
Contributor
Author
|
Also fixes this error on CI. |
Contributor
Author
|
Thanks @yoshoku! |
Owner
|
@ankane Thank you for your contribution! I am not very familiar with TruffleRuby, so your help was greatly appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Hi @yoshoku, this PR fixes a compilation error with TruffleRuby.
Summary of Changes
Uses
RBASIC_FLAGSandRBASIC_SET_FLAGSto access flags as recommended in truffleruby/truffleruby#3751.Testing
There are still 16 test failures with TruffleRuby, which can hopefully be addressed in future PRs (see the discussion in truffleruby/truffleruby#3751).
Related Issues
None