Partial fix for repeat|repeat-x|repeat-y#28
Open
georgevreilly wants to merge 2 commits intoyostudios:masterfrom
Open
Partial fix for repeat|repeat-x|repeat-y#28georgevreilly wants to merge 2 commits intoyostudios:masterfrom
georgevreilly wants to merge 2 commits intoyostudios:masterfrom
Conversation
Images still included in sprite, however
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a
backgrounddeclaration includesrepeat,repeat-x, orrepeat-y, it is not rewritten by the replacer. The image, however, is still included in the sprite. If the repeat-style isno-repeat, thebackgrounddeclaration continues to be rewritten, of course.This is not sufficient if there's an explicit
background-repeatdeclaration.Ideally, there would be more smarts for
repeat-xandrepeat-y. See Stoyan for some ideas on how to handle such cases.