YPE-1159 - useChapter and useChapters tests #135
+452
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Kyleasmth
commented
Feb 3, 2026
Kyleasmth
commented
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Greptile OverviewGreptile SummaryAdded comprehensive test suites for Key changes:
Minor gaps:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as Test Suite
participant Hook as useChapter/useChapters
participant Client as BibleClient (mocked)
participant API as useApiData
Test->>Hook: renderHook(versionId, book, chapter?)
Hook->>Client: useBibleClient()
Client-->>Hook: mockClient
Hook->>API: useApiData(fetchFn, deps, options)
API-->>Hook: {data, loading: true, error, refetch}
Hook-->>Test: {chapter/chapters: null, loading: true}
Note over API: useEffect triggered
API->>Client: getChapter(versionId, book, chapter)
Client-->>API: Promise<BibleChapter>
API-->>Hook: {data: chapter, loading: false}
Hook-->>Test: {chapter: mockChapter, loading: false}
Test->>Hook: rerender with new params
Note over API: Dependencies changed
API->>Client: getChapter(newVersionId, book, chapter)
Client-->>API: Promise<BibleChapter>
Hook-->>Test: Updated chapter data
Test->>Hook: result.current.refetch()
Hook->>API: refetch()
API->>Client: getChapter(versionId, book, chapter)
Client-->>API: Promise<BibleChapter>
Hook-->>Test: Refetched chapter data
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+159
to
+175
| it('should handle fetch errors', async () => { | ||
| const error = new Error('Failed to fetch chapter'); | ||
| mockGetChapter.mockRejectedValueOnce(error); | ||
|
|
||
| const wrapper = createWrapper({ | ||
| appKey: mockAppKey, | ||
| }); | ||
|
|
||
| const { result } = renderHook(() => useChapter(1, 'MAT', 1), { wrapper }); | ||
|
|
||
| await waitFor(() => { | ||
| expect(result.current.loading).toBe(false); | ||
| }); | ||
|
|
||
| expect(result.current.error).toEqual(error); | ||
| expect(result.current.chapter).toBe(null); | ||
| }); |
Contributor
There was a problem hiding this comment.
Missing test for error recovery. useVersion.test.tsx:188 and useVersions.test.tsx:587 include tests verifying that errors are cleared after a successful refetch using mockRejectedValueOnce(error).mockResolvedValueOnce(data) pattern
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/hooks/src/useChapter.test.tsx
Line: 159:175
Comment:
Missing test for error recovery. `useVersion.test.tsx:188` and `useVersions.test.tsx:587` include tests verifying that errors are cleared after a successful refetch using `mockRejectedValueOnce(error).mockResolvedValueOnce(data)` pattern
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+133
to
+149
| it('should handle fetch errors', async () => { | ||
| const error = new Error('Failed to fetch chapters'); | ||
| mockGetChapters.mockRejectedValueOnce(error); | ||
|
|
||
| const wrapper = createWrapper({ | ||
| appKey: mockAppKey, | ||
| }); | ||
|
|
||
| const { result } = renderHook(() => useChapters(1, 'MAT'), { wrapper }); | ||
|
|
||
| await waitFor(() => { | ||
| expect(result.current.loading).toBe(false); | ||
| }); | ||
|
|
||
| expect(result.current.error).toEqual(error); | ||
| expect(result.current.chapters).toBe(null); | ||
| }); |
Contributor
There was a problem hiding this comment.
Missing test for error recovery. useVersion.test.tsx:188 and useVersions.test.tsx:587 include tests verifying that errors are cleared after a successful refetch using mockRejectedValueOnce(error).mockResolvedValueOnce(data) pattern
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/hooks/src/useChapters.test.tsx
Line: 133:149
Comment:
Missing test for error recovery. `useVersion.test.tsx:188` and `useVersions.test.tsx:587` include tests verifying that errors are cleared after a successful refetch using `mockRejectedValueOnce(error).mockResolvedValueOnce(data)` pattern
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.