Update yosys submodule#3
Draft
github-actions[bot] wants to merge 292 commits into
Draft
Conversation
github-actions
Bot
force-pushed
the
update-yosys
branch
2 times, most recently
from
32c17ab to
23c065b
Compare
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
…t-staging/negotiation-metrics metrics update after enabling negotiation legalizer
[WARNING TAP-0014] endcap_cpp option is deprecated. Remove this deprecated option, since it's not used in OpenROAD's tapcell module anymore. Also clean up the uart-blocks design for gf180. Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
Commit df79ba1 ("make: immediately expand deferred vars") changed the tool-path setup from export OPENROAD_EXE ?= $(abspath ...) to OPENROAD_EXE ?= $(abspath ...) export OPENROAD_EXE := $(OPENROAD_EXE) The := reassign gives the variable origin "file" even when the value was supplied through the environment. UNSET_VARIABLES_NAMES collects every file-origin variable and $(UNSET_AND_MAKE) unsets them in the bash wrapper before invoking the submake. That strips a caller- supplied OPENROAD_EXE / OPENSTA_EXE / YOSYS_EXE from the submake's environment, and variables.mk re-derives them via the $(FLOW_HOME)/../tools/install/... fallback — a path that does not exist in hermetic builds (e.g. bazel-orfs). Extend the unset exclusion list to cover OPENROAD%, OPENSTA%, YOSYS%, mirroring the KLAYOUT% entry already there for the same reason. This restores the pre-df79ba1d9 behavior for callers that pass tool paths through the environment, without reverting the immediate- expansion fix. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
PYTHON_EXE follows the same `?=` then `export := $(PYTHON_EXE)` pattern as OPENROAD_EXE / OPENSTA_EXE / YOSYS_EXE, so a caller-supplied value is similarly stripped by UNSET_AND_MAKE because the re-export gives it origin "file". Add PYTHON% to the exclusion list alongside the other tool prefixes. Addresses gemini-code-assist review feedback on PR The-OpenROAD-Project#4159. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
…cap_cpp-deprecated platforms: gf180: endcap_cpp is deprecated
this update also points to a more recent OR submodule, so includes later missing updates ===================================================== make update_ok for gcd (rapidus2hp)... ===================================================== designs/rapidus2hp/gcd/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -0.697 | -0.76 | Failing | | globalroute__timing__setup__tns | -1.29 | -1.14 | Tighten | | finish__timing__setup__tns | -1.29 | -1.14 | Tighten | | finish__design__instance__area | 33 | 32 | Tighten | ===================================================== make update_ok for gcd (rapidus2hp) (verific)... ===================================================== designs/rapidus2hp/gcd/rules-verific.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -1.26 | -1.25 | Tighten | | globalroute__timing__setup__ws | -0.0502 | -0.0494 | Tighten | | globalroute__timing__setup__tns | -1.79 | -1.64 | Tighten | | finish__timing__setup__ws | -0.0502 | -0.0494 | Tighten | | finish__timing__setup__tns | -1.79 | -1.64 | Tighten | ===================================================== make update_ok for ethmac (rapidus2hp)... ===================================================== designs/rapidus2hp/ethmac/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -1.76 | -1.78 | Failing | | globalroute__timing__setup__tns | -3.11 | -3.1 | Tighten | | finish__timing__setup__tns | -3.11 | -3.1 | Tighten | | finish__design__instance__area | 3298 | 3297 | Tighten | ===================================================== make update_ok for ethmac (rapidus2hp) (verific)... ===================================================== designs/rapidus2hp/ethmac/rules-verific.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -1.6 | -1.81 | Failing | | globalroute__timing__setup__tns | -2.59 | -3.03 | Failing | | finish__timing__setup__tns | -2.59 | -3.03 | Failing | ===================================================== make update_ok for jpeg (rapidus2hp)... ===================================================== designs/rapidus2hp/jpeg/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__ws | -0.0564 | -0.0551 | Tighten | | globalroute__timing__setup__tns | -31.9 | -26.2 | Tighten | ===================================================== make update_ok for jpeg (rapidus2hp) (verific)... ===================================================== designs/rapidus2hp/jpeg/rules-verific.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__ws | -0.0712 | -0.0527 | Tighten | | globalroute__timing__setup__tns | -33.5 | -26.5 | Tighten | ===================================================== make update_ok for hercules_idecode (rapidus2hp)... ===================================================== designs/rapidus2hp/hercules_idecode/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__ws | -0.0953 | -0.12 | Failing | | globalroute__timing__setup__tns | -97.2 | -80.4 | Tighten | ===================================================== make update_ok for hercules_idecode (rapidus2hp) (verific)... ===================================================== designs/rapidus2hp/hercules_idecode/rules-verific.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__tns | -224.0 | -154.0 | Tighten | ===================================================== make update_ok for hercules_is_int (rapidus2hp)... ===================================================== designs/rapidus2hp/hercules_is_int/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -368.0 | -442.0 | Failing | | globalroute__timing__setup__ws | -0.263 | -0.241 | Tighten | | globalroute__timing__setup__tns | -1050.0 | -1040.0 | Tighten | | globalroute__timing__hold__tns | -0.703 | -0.947 | Failing | ===================================================== make update_ok for hercules_is_int (rapidus2hp) (verific)... ===================================================== designs/rapidus2hp/hercules_is_int/rules-verific.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -332.0 | -331.0 | Tighten | | globalroute__timing__setup__ws | -0.212 | -0.251 | Failing | | globalroute__timing__setup__tns | -983.0 | -1190.0 | Failing | | globalroute__timing__hold__ws | -0.0125 | -0.037 | Failing | ===================================================== make update_ok for ibex (rapidus2hp)... ===================================================== designs/rapidus2hp/ibex/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__ws | -0.0882 | -0.0777 | Tighten | | globalroute__timing__setup__tns | -43.3 | -20.4 | Tighten | ===================================================== make update_ok for ibex (rapidus2hp) (verific)... ===================================================== designs/rapidus2hp/ibex/rules-verific.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -0.0452 | -0.0415 | Tighten | | cts__timing__setup__tns | -0.26 | -0.578 | Failing | | globalroute__timing__setup__tns | -25.3 | -28.6 | Failing | ===================================================== make update_ok for ariane (gf12)... ===================================================== designs/gf12/ariane/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | placeopt__design__instance__area | 214069 | 213164 | Tighten | | globalroute__antenna_diodes_count | 180 | 179 | Tighten | | detailedroute__route__wirelength | 3948737 | 3769820 | Tighten | | detailedroute__antenna_diodes_count | 180 | 179 | Tighten | | finish__design__instance__area | 216316 | 215570 | Tighten | ===================================================== make update_ok for gcd (gf12)... ===================================================== designs/gf12/gcd/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | synth__design__instance__area__stdcell | 111.0 | 107.0 | Tighten | ===================================================== make update_ok for jpeg (gf12)... ===================================================== designs/gf12/jpeg/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | synth__design__instance__area__stdcell | 20440.28 | 19900.0 | Tighten | | placeopt__design__instance__count__stdcell | 102448 | 95595 | Tighten | | cts__timing__setup__ws | -99.1 | -58.6 | Tighten | | cts__timing__setup__tns | -23600.0 | -10300.0 | Tighten | | globalroute__timing__setup__ws | -198.0 | -53.2 | Tighten | | globalroute__timing__setup__tns | -13200.0 | -7010.0 | Tighten | | finish__timing__setup__ws | -207.0 | -25.0 | Tighten | | finish__timing__setup__tns | -3360.0 | -100.0 | Tighten | ===================================================== make update_ok for bp_single (gf12)... ===================================================== designs/gf12/bp_single/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__hold__tns | -4460.0 | -3310.0 | Tighten | ===================================================== make update_ok for tinyRocket (gf12)... ===================================================== designs/gf12/tinyRocket/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -166.0 | -160.0 | Tighten | | finish__timing__hold__tns | -545.0 | -160.0 | Tighten | ===================================================== make update_ok for coyote (gf12)... ===================================================== designs/gf12/coyote/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | placeopt__design__instance__area | 197211 | 196510 | Tighten | | placeopt__design__instance__count__stdcell | 319739 | 316293 | Tighten | | cts__design__instance__count__setup_buffer | 27803 | 27504 | Tighten | | cts__design__instance__count__hold_buffer | 27803 | 27504 | Tighten | | globalroute__antenna_diodes_count | 264 | 261 | Tighten | | detailedroute__route__wirelength | 4257073 | 4125688 | Tighten | | detailedroute__antenna_diodes_count | 264 | 261 | Tighten | | finish__design__instance__area | 201687 | 200742 | Tighten | ===================================================== make update_ok for swerv_wrapper (gf12)... ===================================================== designs/gf12/swerv_wrapper/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | placeopt__design__instance__area | 173119 | 172761 | Tighten | | cts__timing__setup__ws | -171.0 | -75.0 | Tighten | | cts__timing__hold__ws | -197.0 | -104.0 | Tighten | | cts__timing__hold__tns | -671.0 | -376.0 | Tighten | | globalroute__antenna_diodes_count | 107 | 106 | Tighten | | detailedroute__route__wirelength | 2518773 | 2307185 | Tighten | | detailedroute__antenna_diodes_count | 107 | 106 | Tighten | | finish__design__instance__area | 177792 | 177526 | Tighten | ===================================================== make update_ok for ibex (gf12)... ===================================================== designs/gf12/ibex/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__design__instance__count__hold_buffer | 1752 | 1664 | Tighten | ===================================================== make update_ok for ca53 (gf12)... ===================================================== designs/gf12/ca53/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | finish__timing__hold__tns | -3000.0 | -2170.0 | Tighten | Large percentage changes in failing metrics (>50%): - hercules_is_int (rapidus2hp (verific)) globalroute__timing__hold__ws 196.00% (-0.0125 → -0.037) - ibex (rapidus2hp (verific)) cts__timing__setup__tns 122.31% (-0.26 → -0.578) Large percentage improvements in tighten metrics (>50%): - jpeg (gf12) finish__timing__setup__tns -97.02% (-3360.0 → -100.0) - jpeg (gf12) finish__timing__setup__ws -87.92% (-207.0 → -25.0) - jpeg (gf12) globalroute__timing__setup__ws -73.13% (-198.0 → -53.2) - tinyRocket (gf12) finish__timing__hold__tns -70.64% (-545.0 → -160.0) - jpeg (gf12) cts__timing__setup__tns -56.36% (-23600.0 → -10300.0) - swerv_wrapper (gf12) cts__timing__setup__ws -56.14% (-171.0 → -75.0) - ibex (rapidus2hp) globalroute__timing__setup__tns -52.89% (-43.3 → -20.4) Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Ashnaa Seth <ashnaaseth2325@gmail.com>
…fix/wdt32-wden-p-reset WDT32: Add reset to wden_p to fix WDOV X-propagation after reset
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
…t-staging/secure-dpl-negotiation-fixes update metrics for dpl fixes
…oad-rsz-core-clamp Signed-off-by: minjukim55 <mkim@precisioninno.com> # Conflicts: # tools/OpenROAD
`export OPENROAD_EXE := $(OPENROAD_EXE)` rebinds the variable to origin "file", which puts it on the UNSET_VARIABLES_NAMES list that UNSET_AND_MAKE clears before invoking a sub-make. In sub-make the variable is gone and the `?=` fallback resolves to the in-tree `tools/install/OpenROAD/bin/openroad` path that does not exist in a Bazel sandbox, so every stage invoked via UNSET_AND_MAKE (floorplan, place, route, final) fails with "openroad: No such file or directory". Using a bare `export` preserves the original origin (environment when bazel-orfs supplies it, file when the local default fills in) so the env value survives the UNSET_VARS step and sub-makes see the right binary. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Same origin-rebinding trap as the parent commit: `export VAR := $(VAR)` made PYTHON_EXE and YOSYS_EXE get caught by UNSET_VARIABLES_NAMES and cleared before sub-makes, so any caller relying on an environment- supplied value (e.g. bazel-orfs passing YOSYS_EXE) silently fell back to the in-tree tools/install path. Switch both to the bare `export` pattern and leave a "here be dragons" comment block near PYTHON_EXE explaining why you must not "tidy up" these lines into `export VAR := $(VAR)`. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
It was previously getting it from the OpenROAD dependency installer but that was removed. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
…t-staging/yosys-readline Add readline to the dependency installer for yosys
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
…t-staging/open-ccs Mirror LIB_MODEL CCS handling from load.tcl to open.tcl
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
etc: fix dependency install order
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…t-staging/secure-fix_missing_para_dbmodnet Secure fix missing para dbmodnet
Copy LICENSE files from tool source trees into tools/install/licenses/ so they are included in the final image. Excludes tools/OpenROAD/src/sta. Fixes: https://github.com/The-OpenROAD-Project/AutoTuner/issues/146 Signed-off-by: Jack Luar <jluar@precisioninno.com>
Prevent find from re-discovering already-copied license files in the install destination, and handle paths with spaces correctly. Signed-off-by: Jack Luar <jluar@precisioninno.com>
Copy LICENSE files from tool source trees into tools/install/licenses/ so they are included in the final image. Excludes tools/OpenROAD/src/sta. Fixes: https://github.com/The-OpenROAD-Project/AutoTuner/issues/146 Signed-off-by: Jack Luar <jluar@precisioninno.com>
Prevent find from re-discovering already-copied license files in the install destination, and handle paths with spaces correctly. Signed-off-by: Jack Luar <jluar@precisioninno.com>
…s/OpenROAD-flow-scripts into feat/include-tool-licenses
Picks up the Kogge-Stone adder memory corruption fix in yosys 0.64
that triggered ABC SIGSEGVs under yosys 0.63 + abc 0.62-yosyshq.
- Bump BAZEL_ORFS_COMMIT to 6ebadeb, which moves yosys to 0.64.
- Drop the vendored render_gds PDK_CONFIGS patch and the now-empty
patches/bazel-orfs/ directory: the fix landed upstream in bazel-orfs
commit bfd3a1d ("render_gds: monkey-patch PDK_CONFIGS instead of
gdsii_use_custom_config"), so the patches= argument and its sole
entry are no longer needed.
- Mirror bazel-orfs/.bazelrc's --registry= lines into root .bazelrc so
yosys 0.64 resolves from the unmerged BCR PR (bazelbuild/bazel-
central-registry#8862) fork until that PR lands. ORFS has its own
.bazelrc, so bazel-orfs's lines don't propagate automatically.
- abc 0.64-yosyshq.bcr.1 is already on official BCR; only yosys 0.64
requires the fallback registry.
Local test: bazelisk test //flow/designs/asap7/... --keep_going:
mock-alu (kogge-stone exerciser) PASSES with yosys/abc 0.64.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
…bump-yosys-0.64 bazel-orfs: bump and get yosys/abc 0.64 via custom registry
Bring in OR PR: skip ensureWireParasitic in repair_design hot path via load_cap hint, gated on kGlobalRouting parasitics. OR PR: The-OpenROAD-Project-private/OpenROAD#3434 Issue: The-OpenROAD-Project-private/OpenROAD-flow-scripts#1676 Signed-off-by: Minju Kim <mkim@precisioninno.com>
ariane133 nangate45 and microwatt sky130hd see small setup TNS drift from the cell-selection change in OR PR #10507; bump thresholds with ~5% margin around the new measured values. Related: The-OpenROAD-Project-private/OpenROAD-flow-scripts#1676 Signed-off-by: Minju Kim <mkim@precisioninno.com>
…t-staging/secure-rsz-issue1676-v2 bump OpenROAD: rsz repair_design hot path optimization
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
github-actions
Bot
force-pushed
the
update-yosys
branch
from
feaee24 to
4e05ebb
Compare
…t-staging/secure-or_fix_rep_des_crash update openroad to fix repair design crash
…t-staging/secure-or_fix_rep_des_crash update openroad to fix repair design crash
…-tool-licenses feat(docker): collect tool LICENSE files into install dir
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
Bot
force-pushed
the
update-yosys
branch
from
4e05ebb to
485636c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action