fix(notify): kwargs handling + README SMS docs#185
Merged
ywatanabe1989 merged 2 commits intomainfrom Mar 14, 2026
Merged
Conversation
…with SMS The alert_async() was passing **kwargs to get_backend(), which caused TwilioBackend.__init__() to fail on unknown args like 'fallback'. Backend constructors use env vars; send() receives kwargs separately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kwargs.get("to_number", self.to_number) returns None when key exists
with None value. Use `or self.to_number` to fall back to instance default.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alert_async()passing irrelevant kwargs to backend constructors (causedcall()to always fail from CLI)TwilioBackend.send()treatingNonekwargs as overrides instead of falling back to env varsTest plan
scitex notify call "test"— now works (was failing)scitex notify sms "test"— worksscitex notify backends— worksscitex mcp list-tools -m notify— shows 5 tools🤖 Generated with Claude Code