Merged
Conversation
Verify all claims against actual codebase via 6-model review (2 iterations). Key fixes: - Add --visible-only, --mkvmerge-path, --ffmpeg-path CLI flags - Fix Play All threshold (>10min -> >=5min) and archive filename pattern - Add commentary category, menu_visible field, disc title fallback chain - Complete JSON schema example (segments, in_time, out_time, segment_key, play_item_ref, chapter_start, context, top-level streams) - Fix confidence table (0.85 collapse paths, universal IG boost) - Fix pipeline description (classify not cluster, correct step ordering) - Fix fixture count (28 not 29), add digital_archive.py to tree - Document BDMV parent dir auto-resolve, ffmpeg requirement Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: comprehensive README accuracy rewrite
Summary
Rewrites README.md to match the actual codebase after a 6-model multi-pass review (claude-opus-4.6, claude-sonnet-4.6, gpt-5.4, gpt-5.3-codex, gpt-5.2, gemini-3-pro-preview). Two iterations were required to reach convergence (all dimensions 8+/10). Fixes 19 findings spanning factual errors, missing features, and incomplete schema documentation.
Background
The README had drifted from the implementation — CLI flags were undocumented, the JSON schema example omitted fields, thresholds were wrong, and special-feature categories were incomplete. This was identified during a structured "iterate-hardcore" review that cross-references every README claim against the source code.
Changes
CLI documentation:
--visible-onlyflag toremuxandarchivecommand docs--mkvmerge-pathand--ffmpeg-pathoptions--ffmpegto Installation requirementscommentaryto special-feature category listsFactual corrections:
>10 min→≥5 min(matches_EPISODE_ITEM_MIN_S = 300){stem}-{index:03d}-{clip_id}.{ext}{name}source: disc title fromMETA/DL/bdmt_eng.xmlwithbdmt_*.xmlfallback, then folder nameJSON schema example:
in_time,out_time,segment_keyto play itemsplay_item_ref,duration_msto chaptersstreamsarray on playlistssegmentsarray on episodes (alongsidescenes)contexton warningschapter_startfield on special featuresConfidence table:
Title-hint collapse(0.85) andVariant-dedup collapse(0.85) rowsOther:
[visible]/[hidden]labels and total/visible countsmenu_visibleto scan output descriptiondigital_archive.py,remux/,util/,.github/to project structure treeTesting
ruff check .— all checks passedruff format --check .— 69 files already formattedpytest tests/ -q— 452 passed