fix: preserve existing data in update_excel function#4
Open
aymed10 wants to merge 1 commit intoyzfly:mainfrom
Open
fix: preserve existing data in update_excel function#4aymed10 wants to merge 1 commit intoyzfly:mainfrom
aymed10 wants to merge 1 commit intoyzfly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When calling update_excel to modify an existing Excel file (e.g. adding a new column), the function replaces the entire sheet with only the data sent by the LLM. All rows and untouched columns that weren't included in the update payload are lost.
Root Cause
The function writes new_df (the incoming data) directly to the sheet without first loading and merging with the existing sheet content.
Fix
Load the existing sheet first, merge the new columns into it, then save.