Skip to content

docs(instructions): mark Conventional Commits/trailer check as target policy #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ss-o merged 1 commit into from
Jul 25, 2026
Merged

docs(instructions): mark Conventional Commits/trailer check as target policy #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/instructions/testing.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,24 @@ definitions come from `decisions/0007-release-publication-flow.md`.

## Identify the class first

| Class | Repos | What it is |
| ----- | --------------------------------------- | -------------------------------- |
| 1 | `wiki`, `src`, `zd` | Continuously deployed artifact |
| 2 | `zunit`, `zsh-lint`, packaged `zsh` | Versioned tool/package |
| 3 | `zi`, most plugins/annexes | Git-consumed source |
| 4 | `.github` | Meta/infrastructure |
| Class | Repos | What it is |
| ----- | ----------------------------------- | ------------------------------ |
| 1 | `wiki`, `src`, `zd` | Continuously deployed artifact |
| 2 | `zunit`, `zsh-lint`, packaged `zsh` | Versioned tool/package |
| 3 | `zi`, most plugins/annexes | Git-consumed source |
| 4 | `.github` | Meta/infrastructure |

## Baseline (every repo)

- Workflows follow org conventions: SHA-pinned actions, top-level
least-privilege `permissions:`, `concurrency:` on push/PR, no-emoji workflow/
job `name:` (ADR-0005), kebab-case filenames.
- Zsh sources pass `zsh -n` and `zcompile`.
- Conventional Commits (ADR-0003) and the disallowed-trailer check are enforced.
- Conventional Commits (ADR-0003) and the disallowed-trailer rule are target
policy: follow them by habit when authoring commits and PR titles. A sweep
of all 86 active repositories found no workflow enforcing either one on a
default branch (see `decisions/0009-testing-ci-strategy.md` and issue
#454), so do not assume CI will catch a violation.

## By class

Expand Down
Loading