feat(agent): add portable learning capture gate - #492
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit “learning capture” completion gate to the org’s agent policy, with a canonical runbook and an optional Copilot-only advisory skill, all routed via the public instruction manifest and covered by policy validation tests.
Changes:
- Introduce
runbooks/learning-capture.mdas the canonical workflow for learning/reuse review before declaring non-trivial work complete. - Update
AGENTS.mdto require the learning capture review while keeping “No durable learning” as a valid silent outcome. - Register the new runbook and advisory skill in
.github/instruction-surfaces.jsonand add a unit test to assert their manifest declarations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/test_validate_agent_policy.py | Adds assertions that the new learning-capture runbook surface and the advisory skill are declared in the public manifest. |
| runbooks/learning-capture.md | New canonical runbook defining the learning-capture workflow, routing/destination rules, and authority boundaries. |
| AGENTS.md | Makes learning capture a mandatory completion step for non-trivial work, delegating detailed workflow guidance to the runbook. |
| .github/skills/review-project-learning/SKILL.md | Adds an optional Copilot skill that guides users through the learning-capture workflow without expanding authority. |
| .github/README.md | Documents the new runbook and skill as part of the instruction architecture. |
| .github/instruction-surfaces.json | Registers the new runbook surface (required) and the advisory skill surface (optional) for manifest-based routing. |
| @@ -0,0 +1,147 @@ | |||
| # Runbook - Learning capture | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claimed complete
No durable learningas a valid silent outcomewrites
This implements the policy portion of #482. The issue remains open for its
30-task or four-week measurement pilot.
Instruction impact review
optional advisory skill.
Gemini CLI is deprecated and is not a verification target.
AGENTS.mdowns the mandatory gate,runbooks/learning-capture.mdowns workflow detail, and the skill remainsadvisory.
separately owned delivery step.
or a hook.
pass.
Validation
python3 -B scripts/validate-agent-policy.pypython3 -B -m unittest scripts/test_validate_agent_policy.py -v(70 tests passed)
trunk check --no-fix --forceon all six changed filesgit diff --check origin/main...HEADRuntime discovery evidence
tools disabled.
Safety boundaries
documentation write path