Skip to content

feat(agent): add portable learning capture gate - #492

Merged
ss-o merged 1 commit into
mainfrom
codex/learning-capture-publication
Jul 29, 2026
Merged

feat(agent): add portable learning capture gate#492
ss-o merged 1 commit into
mainfrom
codex/learning-capture-publication

Conversation

@ss-o

@ss-o ss-o commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • require a lightweight learning and reuse review before non-trivial work is
    claimed complete
  • add one canonical learning-capture runbook and an optional advisory skill
  • route and validate both surfaces through the public instruction manifest
  • keep No durable learning as a valid silent outcome
  • preserve explicit authority for memory, issue, policy, and documentation
    writes

This implements the policy portion of #482. The issue remains open for its
30-task or four-week measurement pilot.

Instruction impact review

  1. This is shared mandatory policy plus canonical runbook detail and one
    optional advisory skill.
  2. Codex, Claude Code, Copilot, and humans receive the baseline and runbook.
    Gemini CLI is deprecated and is not a verification target.
  3. AGENTS.md owns the mandatory gate,
    runbooks/learning-capture.md owns workflow detail, and the skill remains
    advisory.
  4. No competing learning log or memory owner is introduced.
  5. The public manifest inventories the runbook and skill. Private routing is a
    separately owned delivery step.
  6. Mandatory behavior reaches supported runtimes without relying on the skill
    or a hook.
  7. Public manifest tests, policy validation, and the instruction size limit
    pass.

Validation

  • python3 -B scripts/validate-agent-policy.py
  • python3 -B -m unittest scripts/test_validate_agent_policy.py -v
    (70 tests passed)
  • trunk check --no-fix --force on all six changed files
  • git diff --check origin/main...HEAD

Runtime discovery evidence

  • Codex: verified in a fresh task.
  • GitHub Copilot CLI: verified through direct repository skill discovery with
    tools disabled.
  • Claude Code: unverified because the bounded check exceeded its budget.
  • Gemini CLI: deprecated and not invoked.

Safety boundaries

  • no automatic memory, issue, ADR, runbook, instruction, skill, or
    documentation write path
  • no Codex hook
  • no private workspace paths or data

Copilot AI review requested due to automatic review settings July 29, 2026 23:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an explicit “learning capture” completion gate to the org’s agent policy, with a canonical runbook and an optional Copilot-only advisory skill, all routed via the public instruction manifest and covered by policy validation tests.

Changes:

  • Introduce runbooks/learning-capture.md as the canonical workflow for learning/reuse review before declaring non-trivial work complete.
  • Update AGENTS.md to require the learning capture review while keeping “No durable learning” as a valid silent outcome.
  • Register the new runbook and advisory skill in .github/instruction-surfaces.json and add a unit test to assert their manifest declarations.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/test_validate_agent_policy.py Adds assertions that the new learning-capture runbook surface and the advisory skill are declared in the public manifest.
runbooks/learning-capture.md New canonical runbook defining the learning-capture workflow, routing/destination rules, and authority boundaries.
AGENTS.md Makes learning capture a mandatory completion step for non-trivial work, delegating detailed workflow guidance to the runbook.
.github/skills/review-project-learning/SKILL.md Adds an optional Copilot skill that guides users through the learning-capture workflow without expanding authority.
.github/README.md Documents the new runbook and skill as part of the instruction architecture.
.github/instruction-surfaces.json Registers the new runbook surface (required) and the advisory skill surface (optional) for manifest-based routing.

@@ -0,0 +1,147 @@
# Runbook - Learning capture
@ss-o
ss-o marked this pull request as ready for review July 29, 2026 23:44
@ss-o
ss-o requested a review from a team as a code owner July 29, 2026 23:44
@ss-o
ss-o merged commit c91e5f8 into main Jul 29, 2026
8 checks passed
@ss-o
ss-o deleted the codex/learning-capture-publication branch July 29, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants