Skip to content

fix(times): preserve lowercase seconds flag - #372

Merged
ss-o merged 1 commit into
nextfrom
bug-371
Aug 15, 2026
Merged

fix(times): preserve lowercase seconds flag#372
ss-o merged 1 commit into
nextfrom
bug-371

Conversation

@ss-o

@ss-o ss-o commented Aug 15, 2026

Copy link
Copy Markdown
Member

Summary

  • preserve documented zi times -s behavior
  • retain zi times -S and zi times --seconds
  • keep zi update -s mapped to snippets through command-specific option handling

Validation

  • zsh -n zi.zsh lib/zsh/autoload.zsh
  • git diff --check
  • both zi times -s and zi times -S display seconds
  • zi update -s -h still describes snippets-only updates
  • signed commit verified locally

Closes #371.

@ss-o
ss-o requested a review from a team as a code owner August 15, 2026 09:59
Copilot AI balanced review requested due to automatic review settings August 15, 2026 09:59
@ss-o
ss-o merged commit f3e68af into next Aug 15, 2026
23 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores lowercase -s support for zi times while preserving update semantics.

Changes:

  • Adds command-specific -s descriptions.
  • Supports -s, -S, and --seconds for timing output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
zi.zsh Adds lowercase seconds option parsing.
lib/zsh/autoload.zsh Handles lowercase -s as seconds for times.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread zi.zsh
-p opt_-p,--parallel:"Turn on concurrent, multi-thread update (of all objects)."
--parallel opt_-p,--parallel
-s opt_-s,--snippets:"Update only snippets (i.e.: skip updating plugins)."
-s opt_-s,--snippets:"update:[Update only snippets (i.e.: skip updating plugins).] times:[Show times in seconds.]"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants