chore(meta): audit and trim repository metadata - #375
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 29 changed files in this pull request and generated 2 comments.
Suppressed comments (5)
.github/workflows/commit-lint.yml:75
- The PR-title check omits the policy-approved
buildandstyletypes, so valid Conventional Commit titles are blocked. Keep this pattern aligned with the commit validator and organization policy.
PATTERN='^(feat|fix|perf|refactor|docs|test|ci|chore|revert)(\([^)]+\))?!?: .{1,72}$'
.github/workflows/commit-lint.yml:37
- The canonical Conventional Commits policy also allows
buildandstyle, so this validator rejects organization-valid commits. Include both types in the pattern.
CONVENTIONAL_PATTERN='^(feat|fix|perf|refactor|docs|test|ci|chore|revert)(\([^)]+\))?!?: .{1,72}$'
.github/PULL_REQUEST_TEMPLATE.md:11
- This advertised type list omits the organization-approved
buildandstyletypes, conflicting with the canonical Conventional Commits policy. List the full allowed set so contributors are not told valid titles are invalid.
Types: feat fix perf refactor docs test ci chore revert
.github/PULL_REQUEST_TEMPLATE.md:42
- The repository guidance and validator ban every
Co-authored-bytrailer, not only AI co-author trailers. This narrower checklist wording incorrectly implies human co-author trailers are permitted.
- [ ] No AI co-author trailers in commit messages
.github/PULL_REQUEST_TEMPLATE.md:43
- This checklist now directs contributors to
docs/CONTRIBUTING.md, whose primary guidelines link still targets the removedz-shell/communitypath. Link the live canonical contribution guidelines directly so the repaired PR guidance does not lead users to a dead policy link.
- [ ] I have read [CONTRIBUTING.md](docs/CONTRIBUTING.md)
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.
Suppressed comments (5)
.github/workflows/commit-lint.yml:75
- The PR-title validator also rejects the organization-approved
buildandstyletypes. It must use the same complete type set as the commit validator and canonical policy.
PATTERN='^(feat|fix|perf|refactor|docs|test|ci|chore|revert)(\([^)]+\))?!?: .{1,72}$'
.github/PULL_REQUEST_TEMPLATE.md:42
- The checklist narrows the prohibition to AI trailers, but
AGENTS.md:22bans everyCo-authored-bytrailer. This wording incorrectly implies human co-author trailers are allowed.
- [ ] No AI co-author trailers in commit messages
.github/PULL_REQUEST_TEMPLATE.md:36
- The “Type of change” checklist omits four types advertised above (
test,build,style, andrevert), leaving contributors with no applicable box for those PRs. Include every supported category.
- [ ] `docs` — documentation only
- [ ] `ci` — CI/workflow change
- [ ] `chore` — maintenance / dependency bump
.github/workflows/commit-lint.yml:37
- This validator omits the organization-approved
buildandstyleConventional Commit types, so compliant commits are rejected. Keep the accepted types aligned with the canonical policy.
This issue also appears on line 75 of the same file.
CONVENTIONAL_PATTERN='^(feat|fix|perf|refactor|docs|test|ci|chore|revert)(\([^)]+\))?!?: .{1,72}$'
.github/PULL_REQUEST_TEMPLATE.md:11
- This advertised type list is incomplete: canonical Conventional Commits policy also permits
buildandstyle. As written, the template tells contributors that valid titles are unsupported.
This issue also appears in the following locations of the same file:
- line 34
- line 42
Types: feat fix perf refactor docs test ci chore revert
4de935e to
507a143
Compare
Zi’s repository controls included generic, stale, and ineffective configuration. This change narrows metadata to active languages, generated artifacts, workflows, and GitHub features.
Changes
.editorconfig,.gitattributes, and.gitignore; remove editor-specific and disabled-linter configuration.Co-authored-bytrailer.next..github/dependabot.ymluntil the separately gated Renovate Stage 2 migration is approved.Validation
trunk check --allzsh -nandzcompilefor every tracked Zsh sourceFixes #374