Skip to content

chore(meta): audit and trim repository metadata - #375

Merged
ss-o merged 1 commit into
nextfrom
copilot/chore-audit-trim-repository-metadata
Aug 15, 2026
Merged

chore(meta): audit and trim repository metadata#375
ss-o merged 1 commit into
nextfrom
copilot/chore-audit-trim-repository-metadata

Conversation

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown

Zi’s repository controls included generic, stale, and ineffective configuration. This change narrows metadata to active languages, generated artifacts, workflows, and GitHub features.

Changes

  • Minimize .editorconfig, .gitattributes, and .gitignore; remove editor-specific and disabled-linter configuration.
  • Upgrade and focus Trunk, retain one secret scanner, tighten Markdown rules, and run full-repository checks.
  • Repair issue forms with live canonical labels, valid policy links, and Zi-specific prompts.
  • Align the PR template and commit validator with all organization-approved Conventional Commit types and the ban on every Co-authored-by trailer.
  • Apply least-privilege workflow permissions, workflow-qualified concurrency, immutable action pins, and complete Zsh validation for extensionless scripts.
  • Preserve the legacy workflow deletions already present on next.
  • Retain .github/dependabot.yml until the separately gated Renovate Stage 2 migration is approved.

Validation

  • trunk check --all
  • YAML parsing for issue forms, workflows, and Trunk configuration
  • zsh -n and zcompile for every tracked Zsh source
  • action SHA/version-comment and Conventional Commit policy checks

Fixes #374

Copilot AI balanced review requested due to automatic review settings August 15, 2026 10:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI linked an issue Aug 15, 2026 that may be closed by this pull request
8 tasks
Copilot AI review requested due to automatic review settings August 15, 2026 10:39
Copilot AI changed the title [WIP] Audit and trim repository metadata for effectiveness chore(meta): audit and trim repository metadata Aug 15, 2026
Copilot AI requested a review from ss-o August 15, 2026 10:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated 2 comments.

Suppressed comments (5)

.github/workflows/commit-lint.yml:75

  • The PR-title check omits the policy-approved build and style types, so valid Conventional Commit titles are blocked. Keep this pattern aligned with the commit validator and organization policy.
          PATTERN='^(feat|fix|perf|refactor|docs|test|ci|chore|revert)(\([^)]+\))?!?: .{1,72}$'

.github/workflows/commit-lint.yml:37

  • The canonical Conventional Commits policy also allows build and style, so this validator rejects organization-valid commits. Include both types in the pattern.
          CONVENTIONAL_PATTERN='^(feat|fix|perf|refactor|docs|test|ci|chore|revert)(\([^)]+\))?!?: .{1,72}$'

.github/PULL_REQUEST_TEMPLATE.md:11

  • This advertised type list omits the organization-approved build and style types, conflicting with the canonical Conventional Commits policy. List the full allowed set so contributors are not told valid titles are invalid.
    Types: feat  fix  perf  refactor  docs  test  ci  chore  revert

.github/PULL_REQUEST_TEMPLATE.md:42

  • The repository guidance and validator ban every Co-authored-by trailer, not only AI co-author trailers. This narrower checklist wording incorrectly implies human co-author trailers are permitted.
- [ ] No AI co-author trailers in commit messages

.github/PULL_REQUEST_TEMPLATE.md:43

  • This checklist now directs contributors to docs/CONTRIBUTING.md, whose primary guidelines link still targets the removed z-shell/community path. Link the live canonical contribution guidelines directly so the repaired PR guidance does not lead users to a dead policy link.
- [ ] I have read [CONTRIBUTING.md](docs/CONTRIBUTING.md)

Comment thread .github/PULL_REQUEST_TEMPLATE.md
Comment thread .github/workflows/commit-lint.yml
Copilot AI review requested due to automatic review settings August 15, 2026 10:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.

Suppressed comments (5)

.github/workflows/commit-lint.yml:75

  • The PR-title validator also rejects the organization-approved build and style types. It must use the same complete type set as the commit validator and canonical policy.
          PATTERN='^(feat|fix|perf|refactor|docs|test|ci|chore|revert)(\([^)]+\))?!?: .{1,72}$'

.github/PULL_REQUEST_TEMPLATE.md:42

  • The checklist narrows the prohibition to AI trailers, but AGENTS.md:22 bans every Co-authored-by trailer. This wording incorrectly implies human co-author trailers are allowed.
- [ ] No AI co-author trailers in commit messages

.github/PULL_REQUEST_TEMPLATE.md:36

  • The “Type of change” checklist omits four types advertised above (test, build, style, and revert), leaving contributors with no applicable box for those PRs. Include every supported category.
- [ ] `docs` — documentation only
- [ ] `ci` — CI/workflow change
- [ ] `chore` — maintenance / dependency bump

.github/workflows/commit-lint.yml:37

  • This validator omits the organization-approved build and style Conventional Commit types, so compliant commits are rejected. Keep the accepted types aligned with the canonical policy.

This issue also appears on line 75 of the same file.

          CONVENTIONAL_PATTERN='^(feat|fix|perf|refactor|docs|test|ci|chore|revert)(\([^)]+\))?!?: .{1,72}$'

.github/PULL_REQUEST_TEMPLATE.md:11

  • This advertised type list is incomplete: canonical Conventional Commits policy also permits build and style. As written, the template tells contributors that valid titles are unsupported.

This issue also appears in the following locations of the same file:

  • line 34
  • line 42
    Types: feat  fix  perf  refactor  docs  test  ci  chore  revert

@ss-o
ss-o marked this pull request as ready for review August 15, 2026 10:56
@ss-o
ss-o requested a review from a team as a code owner August 15, 2026 10:56
@ss-o
ss-o changed the base branch from main to next August 15, 2026 11:06
@ss-o
ss-o force-pushed the copilot/chore-audit-trim-repository-metadata branch from 4de935e to 507a143 Compare August 15, 2026 11:14
@ss-o ss-o closed this Aug 15, 2026
@ss-o
ss-o deleted the copilot/chore-audit-trim-repository-metadata branch August 15, 2026 11:14
@ss-o
ss-o restored the copilot/chore-audit-trim-repository-metadata branch August 15, 2026 11:15
@ss-o ss-o reopened this Aug 15, 2026

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against the live next baseline and issue #374 acceptance criteria; the scoped metadata changes and repository-native validations are complete.

@ss-o
ss-o merged commit 3f28947 into next Aug 15, 2026
9 of 14 checks passed
@ss-o
ss-o deleted the copilot/chore-audit-trim-repository-metadata branch August 15, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: audit and trim repository metadata

3 participants