changing zc390 to prepare for the java linter - #895
Merged
Conversation
abekornelis
added
enhancement
Zaneham
reviewed
Aug 9, 2026
Zaneham
left a comment
Zaneham
left a comment
Contributor
There was a problem hiding this comment.
Hey Abe, no issues with the code here. I compiled base and head and diffed the javap output across every class, comes out identical, and checkstyle is clean on all four files. Two cosmetic things inline.
|
|
||
| /*************************************************************************** | ||
| * | ||
| /* *************************************************** Maintenance |
Contributor
There was a problem hiding this comment.
This opens with /* *** Maintenance on the same line, while vz390 and tz390 put the banner on its own line. Worth making them match if you care. Same in zCatVAIX and zCatVCLR.
Collaborator
Author
There was a problem hiding this comment.
justifiable. Fixed.
Comment on lines
+25
to
+26
| * 2026-08-06 AFK Fix linter issues | ||
| * 2026-08-07 #807 Fix issues flagged by linter |
Contributor
There was a problem hiding this comment.
Two entries for the same work here. Same in zCatVCLR.
Collaborator
Author
There was a problem hiding this comment.
ouch - copy-past error. Fixed.
Zaneham
previously approved these changes
Aug 9, 2026
Zaneham
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #807
What I did:
I ran the linter (in development; PR #806 ) to validate zc390, zACB, zCatVAIX, zCatVCLR
then fixed all flagged statements. The intention is not to change any code, just whitespace and placement of curly braces.