Skip to content

make ErrTooManySPFRecords exported. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
femaref wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make ErrTooManySPFRecords exported. #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
279e298
make ErrTooManySPFRecords exported.
femaref Sep 10, 2018
5ed5367
missed the reference in the tests
femaref Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,7 @@ func TestSelectingRecord(t *testing.T) {
{"v-spf2", None, ErrSPFNotFound},
{"v-spf10", None, ErrSPFNotFound},
{"no-record", None, ErrSPFNotFound},
{"many-records", Permerror, errTooManySPFRecords},
{"many-records", Permerror, ErrTooManySPFRecords},
{"mixed-records", Pass, nil},
}

Expand Down
4 changes: 2 additions & 2 deletions spf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ var (
ErrDNSLimitExceeded = errors.New("limit exceeded")
ErrSPFNotFound = errors.New("SPF record not found")
errInvalidCIDRLength = errors.New("invalid CIDR length")
errTooManySPFRecords = errors.New("too many SPF records")
ErrTooManySPFRecords = errors.New("too many SPF records")
)

// IPMatcherFunc returns true if ip matches to implemented rules.
Expand Down Expand Up @@ -202,7 +202,7 @@ func filterSPF(txt []string) (string, error) {
n++
}
if n > 1 {
return "", errTooManySPFRecords
return "", ErrTooManySPFRecords
}
return spf, nil
}
Expand Down