fix: resolve 406 error on pipeline step log by using correct Accept header#2
Open
alionar wants to merge 3 commits intozach-snell:mainfrom
Open
fix: resolve 406 error on pipeline step log by using correct Accept header#2alionar wants to merge 3 commits intozach-snell:mainfrom
alionar wants to merge 3 commits intozach-snell:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bbkt pipelines logand the MCPget-step-logaction both fail withHTTP 406 Not Acceptable.The
do()method inclient.gohardcodesAccept: application/jsonon every request. Problem is, the step log endpoint (/2.0/repositories/.../steps/{uuid}/log) only servesapplication/octet-streamand it's raw text, not JSON. So the API rejects the request.GetRaw()was supposed to handle non-JSON responses (it even says "returns raw bytes" in its doc comment), but it callsdo()and inherits the JSON accept header anyway.Fix: added a variadic accept parameter to
do(). Defaults toapplication/jsonso nothing else breaks.GetRaw()now passesapplication/octet-stream.Ref: https://developer.atlassian.com/cloud/bitbucket/rest/api-group-pipelines/#api-repositories-workspace-repo-slug-pipelines-pipeline-uuid-steps-step-uuid-log-get-response
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include commands and environments (e.g. CLI directly, or loaded into Claude Desktop as an MCP server).
go test -race ./...runs successfullygolangci-lint run ./...runs successfullyChecklist: