Fix duplicate folders in export#20
Open
jcul wants to merge 1 commit intozach-snell:masterfrom
Open
Conversation
duplicate folders, e.g. general and b'general'. These changes were made to handle special characters, but they are not proper fixes. I haven't encountered the same issue so reverting them for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests #5 and #13 attempted to fix issues with non ascii characters in channel names or user names.
They don't seem to have fixed the issue properly and caused duplicate folders e.g. "general" and "b'general'.
Revert the changes for now until we find a better fix.
I tested using python3 on linux with channel names "ἐγκύκλιος-παιδεία" and "松弛的出口蛇" and had no issues.