Slack conversations api#29
Open
ax42 wants to merge 2 commits intozach-snell:masterfrom
Open
Conversation
|
It works! Thank you so much!!! 🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the code to Slack's conversations API as the previous APIs have been deprecated (and this caused me the problem described in Issue #26).
This change required some modifications on how to fetch groups to also fetch membership information (as this is no longer part of the API response for a group, and slack-export-viewer fails if there is no membership for a channel). Ideally, the code would do this only for requested groups as it takes time.