Added color code to the result (green, red & yellow)#2
Open
dacacioa wants to merge 2 commits intozandev:masterfrom
Open
Added color code to the result (green, red & yellow)#2dacacioa wants to merge 2 commits intozandev:masterfrom
dacacioa wants to merge 2 commits intozandev:masterfrom
Conversation
|
+1 |
|
Actually, this patch breaks the project's own shUnit2 tests, e.g. e.g. |
Author
|
I fixed the code to pass all the tests. I have pending to implement the yellow color to Assert Failure. |
|
@dacacioa Oh that's fantastic. I really want this feature. I was going to take this patch and try to get it merged upstream in the real shUnit2 https://github.com/kward/shunit2 -- happy to do that, or maybe you would like to do it yourself. I think you would have to rebase since the project moved on a bit after zandev's fork. |
Author
|
@alexharv074 done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added color code to the result to easy check:
Ok -> Green
Failed -> Red
Assert Failure -> Yellow