Update to make WebSocket++ work with modern Asio/Boost#1163
Closed
toonetown wants to merge 1 commit intozaphoyd:developfrom
Closed
Update to make WebSocket++ work with modern Asio/Boost#1163toonetown wants to merge 1 commit intozaphoyd:developfrom
toonetown wants to merge 1 commit intozaphoyd:developfrom
Conversation
Back in 2018, a bunch of Asio stuff was deprecated in Asio 1.12.0/Boost 1.66.0 to reflect the Networking TS. Now that it’s been a while, many of these deprecated functions and interfaces have been removed. As of Asio 1.34.0/Boost 1.87.0, WebSocket++ will not function. This commit makes the following changes and allows for functionality modern versions of Asio/Boost: * Use `io_context` instead of `io_service` * Use `basic_waitable_timer::expiry` instead of `basic_waitable_timer::expires_from_now` * Call `asio::post` instead of `io_context::post` * Use `executor_work_guard` instead of `io_context::work` * Use `resolver::resolve` directly instead of creating `resolver::query` * Use `resolver::results_type` instead of `resolver::iterator directly` * Use `max_listen_connextions` instead of `max_connections` * Use `io_context::restart` instead of `io_context::reset` * Use `make_address` instead of `from_string`
Author
|
Closing this PR in favor of doing a collaboration on #1164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in 2018, a bunch of Asio stuff was deprecated in Asio 1.12.0/Boost 1.66.0 to reflect the Networking TS. Now that it’s been a while, many of these deprecated functions and interfaces have been removed. As of Asio 1.34.0/Boost 1.87.0, WebSocket++ will not function. This commit makes the following changes and allows for functionality modern versions of Asio/Boost:
io_contextinstead ofio_servicebasic_waitable_timer::expiryinstead ofbasic_waitable_timer::expires_from_nowasio::postinstead ofio_context::postexecutor_work_guardinstead ofio_context::workresolver::resolvedirectly instead of creatingresolver::queryresolver::results_typeinstead ofresolver::iterator directlymax_listen_connextionsinstead ofmax_connectionsio_context::restartinstead ofio_context::resetmake_addressinstead offrom_string