Skip to content

Handle Ionic input elements more effectively#368

Merged
thc202 merged 1 commit into
zaproxy:mainfrom
psiinon:ionic
Jun 1, 2026
Merged

Handle Ionic input elements more effectively#368
thc202 merged 1 commit into
zaproxy:mainfrom
psiinon:ionic

Conversation

@psiinon
Copy link
Copy Markdown
Member

@psiinon psiinon commented May 29, 2026

No description provided.

@psiinon
Copy link
Copy Markdown
Member Author

psiinon commented May 29, 2026

Logo
Checkmarx One – Scan Summary & Details3084d652-caaa-47c7-b6bf-73d675511777


New Issues (3) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CVE-2020-13697 Maven-org.nanohttpd:nanohttpd-2.3.1
detailsDescription: An issue was discovered in RouterNanoHTTPD.java in NanoHTTPD through 2.3.1. The GeneralHandler class implements a basic GET handler that prints deb...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
2 MEDIUM CVE-2022-21230 Maven-org.nanohttpd:nanohttpd-2.3.1
detailsDescription: This affects all versions of package org.nanohttpd:nanohttpd. Whenever an HTTP Session is parsing the body of an HTTP request, the body of the requ...
Attack Vector: LOCAL
Attack Complexity: LOW
Vulnerable Package
3 LOW Cxeb68d52e-5509 Maven-commons-codec:commons-codec-1.11
detailsRecommended version: 1.13
Description: Apache commons-codec before 1.13 is vulnerable to information exposure. The Base32 and Base64 implementation blindly decode invalid string, which c...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package

Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes client element lookup so waits become best-effort: if the expected condition does not return an element, the code falls back to a direct findElement lookup. It also updates/adds Selenium-based tests for the new behavior.

Changes:

  • Adds fallback lookup in ZestClientElement.getWebElement.
  • Adds base ZestClientElement tests for fallback/fast-path behavior.
  • Updates submit tests to expect fallback behavior for disabled or late-added elements.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/main/java/org/zaproxy/zest/core/v1/ZestClientElement.java Adds fallback from expected-condition wait to direct element lookup.
src/test/java/org/zaproxy/zest/test/v1/ZestClientElementUnitTest.java Adds tests for fallback and successful wait behavior.
src/test/java/org/zaproxy/zest/test/v1/ZestClientElementSubmitUnitTest.java Updates submit wait tests for the new fallback semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/org/zaproxy/zest/core/v1/ZestClientElement.java
Comment thread src/test/java/org/zaproxy/zest/test/v1/ZestClientElementUnitTest.java Outdated
Comment thread src/test/java/org/zaproxy/zest/test/v1/ZestClientElementUnitTest.java Outdated
@psiinon psiinon force-pushed the ionic branch 2 times, most recently from cbceec7 to e7be9cd Compare May 29, 2026 15:23
@psiinon psiinon marked this pull request as ready for review May 29, 2026 15:26
@thc202 thc202 added this to the 0.36.0 milestone May 29, 2026
@psiinon psiinon force-pushed the ionic branch 2 times, most recently from 15213c7 to cc73fe4 Compare June 1, 2026 10:05
@psiinon psiinon changed the title Fall back to not waiting for elements Handle Ionic input elements more effectively Jun 1, 2026
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
@thc202
Copy link
Copy Markdown
Member

thc202 commented Jun 1, 2026

Thank you!

@thc202 thc202 enabled auto-merge June 1, 2026 10:11
@thc202 thc202 merged commit 3bf2199 into zaproxy:main Jun 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants