Handle Ionic input elements more effectively#368
Merged
Conversation
Member
Author
|
New Issues (3)Checkmarx found the following issues in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
There was a problem hiding this comment.
Pull request overview
This PR changes client element lookup so waits become best-effort: if the expected condition does not return an element, the code falls back to a direct findElement lookup. It also updates/adds Selenium-based tests for the new behavior.
Changes:
- Adds fallback lookup in
ZestClientElement.getWebElement. - Adds base
ZestClientElementtests for fallback/fast-path behavior. - Updates submit tests to expect fallback behavior for disabled or late-added elements.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/main/java/org/zaproxy/zest/core/v1/ZestClientElement.java |
Adds fallback from expected-condition wait to direct element lookup. |
src/test/java/org/zaproxy/zest/test/v1/ZestClientElementUnitTest.java |
Adds tests for fallback and successful wait behavior. |
src/test/java/org/zaproxy/zest/test/v1/ZestClientElementSubmitUnitTest.java |
Updates submit wait tests for the new fallback semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cbceec7 to
e7be9cd
Compare
kingthorin
approved these changes
May 29, 2026
15213c7 to
cc73fe4
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
thc202
approved these changes
Jun 1, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.