Add new maxmind server, fix setup and merge @mnaser's change#1
Open
wolframarnold wants to merge 4 commits intozarqman:masterfrom
Open
Add new maxmind server, fix setup and merge @mnaser's change#1wolframarnold wants to merge 4 commits intozarqman:masterfrom
wolframarnold wants to merge 4 commits intozarqman:masterfrom
Conversation
…'s recommendation
Add Gemfile pointing to gemspec, so that "bundle install" can be used to install development dependencies. (Note: gems should *never* have their Gemfile.lock committed -- see Yehuda Katz's post.) Make compatible with ActiveSupport >= 3.x (for mattr_accessor). Update docs. Test passing :-)
Added conversion to string (fixes bug with recent releases of Ruby)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maxmind added a new, fast, recommended server, maxmind2. This is now the default server chosen, with
maxmind1 and maxmind3 as backups. This is per recent recommendation from Maxmind.
Fixed gemspec and added Gemfile pointing to gemspec, so that bundler can be used to install dependencies and running the test suite becomes more straightforward.
Merged the Ruby 1.9.2 string patch by @mnaser.