fix(build): add an sdist allowlist to zarr-http-server - #4262
Merged
d-v-b merged 2 commits intoAug 13, 2026
Conversation
packages/zarr-http-server had no [tool.hatch.build.targets.sdist] section at all, so hatchling defaulted to 'everything not gitignored' — a blocklist by another name, and the same shape of problem the root pyproject.toml had. Add an explicit allowlist matching the ones packages/zarr-indexing and packages/zarr-metadata already carry. This drops changes/ (towncrier fragments are consumed into CHANGELOG.md at release time), .readthedocs.yaml (only means anything in the repository) and uv.lock, and keeps /examples, which the suite genuinely needs: tests/test_examples.py runs examples/serve.py and executes every cell of examples/serve_notebook.ipynb. Verified from an unpacked sdist: 210 passed, tests/test_examples.py green. Assisted-by: ClaudeCode:claude-opus-5
github-actions
Bot
added
the
needs release notes
d-v-b
marked this pull request as ready for review
August 13, 2026 10:36
Contributor
Author
|
self-merging because it has a small blast radius |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
companion to #4261, scoped to zarr-http-server. we define an allowlist instead of a blocklist for sdist contents.
claude wrote the changes, see d-v-b#290 for the original PR with the bot talk in it.
For reviewers
[What would you most value a second look at? What are you already confident in? For a refactor, say whether behavior is meant to be unchanged.]
Author attestation
TODO
docs/user-guide/*.mdchanges/