Conversation
add flag to Cube Metadata (cc:isHiddenCube)
PublishJob: conditional publishGraph IRI
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1485 +/- ##
==========================================
+ Coverage 80.36% 80.42% +0.06%
==========================================
Files 199 200 +1
Lines 13676 13745 +69
Branches 829 836 +7
==========================================
+ Hits 10991 11055 +64
- Misses 2676 2681 +5
Partials 9 9 ☔ View full report in Codecov by Sentry. |
|
Where should the flag show up in UI?
|
move flag from Cube Metadata to Project (cc:isHiddenCube)
add flag to the published cubes metadata (cc:isHiddenCube)
| return through2.obj( | ||
| (chunk, enc, cb) => cb(null, chunk), | ||
| function (done) { | ||
| dataset.forEach(this.push.bind(this)) | ||
| done() |
There was a problem hiding this comment.
throught2 works of course but for readability, I think generators are the preferred option.
There was a problem hiding this comment.
Also interesting that you used clownface for a single triple :)
fix create/update of project to have flag persisted
complete the property decorator with appropriate type declaration
fix build error
fix unit-tests
tpluscode
left a comment
tpluscode
left a comment
There was a problem hiding this comment.
Please update the requests in e2e-tests
Please add a test scenario in cli/test/lib/commands/publish.test.ts which checks that publishing a hidden cube writes to the expected graph
fix e2e-tests
- property organization.hiddenGraph - testcase 'createPublishJob for hiddenCube' - remove Project.updateIsHiddenCube()
I added a unit test here: apis/core/test/domain/job/create.test.ts |
giacomociti
left a comment
giacomociti
left a comment
There was a problem hiding this comment.
I'm not able to provide nuanced advice, but overall the changes make sense to me
3 participants
cubes metadataProject..../hiddengraph