feature: add support for persistent storage#18
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
zduey
commented
Apr 16, 2026
| raise HTTPException(status_code=500, detail=str(error)) from error | ||
|
|
||
|
|
||
| @router.post("/me/recipes/from-upload", status_code=201) |
Owner
Author
There was a problem hiding this comment.
@claude - This api design has a bad smell to me. Is this a standard way to handle multiple ways to create the same underlying API object? Is there a better way to do this?
| extra="ignore", | ||
| ) | ||
|
|
||
| anthropic_api_key: str | None = None |
Owner
Author
There was a problem hiding this comment.
@claude - Should this be generalized so that we pair an API key with model provider to it's easier to to swap out model providers?
Comment on lines
46
to
47
| supabase_jwt_secret: str | None = None # For HS256 verification (legacy) | ||
| supabase_url: str | None = None # For ES256 JWKS verification |
Owner
Author
There was a problem hiding this comment.
@claude - Should these also be pulled out into a separate config object so that there is less supabase dependency in the general config?
Comment on lines
+56
to
+64
| # Storage configuration | ||
| storage_backend: str = "local" # "local" | "s3" | ||
| storage_local_path: str = "uploads" | ||
| storage_public_base_url: str | None = None # Required for S3 public buckets; auto-set for local | ||
| s3_bucket: str | None = None | ||
| s3_endpoint_url: str | None = None # MinIO, R2, B2 override | ||
| s3_access_key_id: str | None = None | ||
| s3_secret_access_key: str | None = None | ||
| s3_region: str = "us-east-1" |
Owner
Author
There was a problem hiding this comment.
@claude - Should all of this be pulled out to make it easier to swap config for local storage vs. s3 storage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.