fix: kitchen recipe list not showing uploaded thumbnails#26
Merged
Conversation
Recipes with uploaded thumbnails were correctly displayed on the detail page but not in the kitchen shared recipes list. The list endpoint was reading image_url directly from the recipe JSON blob, which only holds the original scraped image, while ignoring the user_recipe.thumbnail_key column where uploaded thumbnails are stored. Fix propagates thumbnail_key through KitchenRecipe and resolves it via StorageBackend in the route handlers for both list and share endpoints, matching the existing pattern used by the main /me/recipes list. https://claude.ai/code/session_01N4wWtQZGRSU79mLwfhKxEK
zduey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_kitchen_recipes()setimage_urlfromrecipe_data.get("image")(the original scraped image URL) while ignoringuser_recipe.thumbnail_key, where uploaded thumbnails are storedthumbnail_keythrough theKitchenRecipeschema and resolves it viaStorageBackendin both the list and share route handlers, matching the existing pattern in/me/recipesTest plan
test_kitchen_recipe_list_uses_thumbnail_when_presentverifies that when a recipe has an uploaded thumbnail, the kitchen recipe list returns the thumbnail URL (not the original image URL)test_kitchen_recipe_list_falls_back_to_original_imageverifies that when no thumbnail is set, the kitchen recipe list falls back to the original recipe image URLhttps://claude.ai/code/session_01N4wWtQZGRSU79mLwfhKxEK