Update continue on error handle docker registry response#25
Closed
anare wants to merge 0 commit intozebox:masterfrom
Closed
Update continue on error handle docker registry response#25anare wants to merge 0 commit intozebox:masterfrom
anare wants to merge 0 commit intozebox:masterfrom
Conversation
Owner
|
Hi, @anare! Please pay attention to several points:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the repository synchronization process in the
DataServiceby handling errors on a per-tag basis rather than aborting the whole sync operation when an error occurs. Now, if a manifest or storage operation fails for a specific tag, the sync will skip only that tag and continue processing the remaining ones. This change ensures more reliable and complete synchronization even in the presence of partial failures.Error handling improvements:
doSyncRepositoriesto skip problematic tags instead of aborting the entire sync operation when a manifest cannot be fetched. The code now logs the error, sets fallback values in the manifest, and continues with the next tag.Code style/organization:
app/store/service/service.gofor consistency and readability.