Skip to content

Update continue on error handle docker registry response#25

Closed
anare wants to merge 0 commit intozebox:masterfrom
anare:master
Closed

Update continue on error handle docker registry response#25
anare wants to merge 0 commit intozebox:masterfrom
anare:master

Conversation

@anare
Copy link
Copy Markdown

@anare anare commented Mar 22, 2026

This pull request improves the robustness of the repository synchronization process in the DataService by handling errors on a per-tag basis rather than aborting the whole sync operation when an error occurs. Now, if a manifest or storage operation fails for a specific tag, the sync will skip only that tag and continue processing the remaining ones. This change ensures more reliable and complete synchronization even in the presence of partial failures.

Error handling improvements:

  • Modified the manifest fetching logic in doSyncRepositories to skip problematic tags instead of aborting the entire sync operation when a manifest cannot be fetched. The code now logs the error, sets fallback values in the manifest, and continues with the next tag.
  • Updated the repository creation logic to skip and continue on non-unique constraint errors, rather than aborting the sync. This prevents a single storage error from stopping the whole process.

Code style/organization:

  • Cleaned up import statements in app/store/service/service.go for consistency and readability.

@zebox
Copy link
Copy Markdown
Owner

zebox commented Mar 23, 2026

Hi, @anare!
I will review you PR some later.

Please pay attention to several points:

  1. Split PR topics to different requests (error sync - one PR, manfiest arch extend - to other..., e.t.c.)
  2. For build multi-arch docker images used goreleaser and offered arch defined in this, linux-arm64 already supported.
  3. After review i will ask you squash all commits of PR to one before PR merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants