Refactor manifest handling for lists and enhance error management#26
Open
anare wants to merge 2 commits intozebox:masterfrom
Open
Refactor manifest handling for lists and enhance error management#26anare wants to merge 2 commits intozebox:masterfrom
anare wants to merge 2 commits intozebox:masterfrom
Conversation
…ove error handling
update: service with showing more wrong manifest repos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for handling Docker image manifest lists (multi-platform images) in the registry service. The changes include new types for manifest lists, updated interfaces and mocks, and new HTTP request logic to accommodate different manifest media types. This enhances the registry's ability to fetch and process both single-architecture and multi-architecture image manifests.
Manifest List and Multi-Platform Support:
ManifestPlatform,ManifestListSchemaItem, andManifestListSchemato represent multi-platform image manifests and their platforms inregistry.go. [1] [2]ManifestSchemeV2,ManifestImageScheme, andManifestListSchemeV2.Registry Interface and Implementation Updates:
Manifestmethod signature to accept a digest and manifest list item, and added a newManifestListmethod to the registry interface and all mocks. [1] [2] [3]newHTTPRequestImage,newHTTPRequestList) to handle different Accept headers and authentication for various manifest types.ManifestandManifestListmethods inregistry.goto use the new types and HTTP logic, supporting both single and multi-platform manifests.Testing and Mock Enhancements:
ManifestList. (F645f281L397R442, [1] [2]Miscellaneous:
storeandengineto comply with Go import grouping conventions. [1] [2]