Skip to content

fix: detect PHPUnit #[Test] attribute with fully-qualified name #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zoispag wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix: detect PHPUnit #[Test] attribute with fully-qualified name #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions languages/php/runnables.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

; Class that follow the naming convention of PHPUnit test classes
; and that doesn't have the abstract modifier
; and have a method that has the #[Test] attribute
; and have a method that has the #[Test] attribute (short or fully-qualified form)
; and the method is public
(
(class_declaration
Expand All @@ -62,7 +62,12 @@
(method_declaration
(attribute_list
(attribute_group
(attribute (name) @_attribute)
(attribute
[
(name) @_attribute
(qualified_name (name) @_attribute)
]
)
)
)
(#eq? @_attribute "Test")
Expand Down