Skip to content

Change outline captures from @name to @context.extra #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vitallium wants to merge 1 commit into from
+16 −16
Closed

Change outline captures from @name to @context.extra #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions languages/ruby/outline.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,16 @@
(call
method: (identifier) @name
arguments: (argument_list . [
(string) @name
(simple_symbol) @name
(scope_resolution) @name
(constant) @name
(string) @context.extra
(simple_symbol) @context.extra
(scope_resolution) @context.extra
(constant) @context.extra
"," @context
Copy link
Copy Markdown
Collaborator Author

@vitallium vitallium May 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this capture should be @context.extra as well?

Copy link
Copy Markdown
Collaborator Author

@vitallium vitallium May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use context.extra here and everywhere else because we will lose ability to search through symbols:

CleanShot.2025-05-10.at.06.57.58.mp4

]* [
(string) @name
(simple_symbol) @name
(scope_resolution) @name
(constant) @name
(string) @context.extra
(simple_symbol) @context.extra
(scope_resolution) @context.extra
(constant) @context.extra
]
)
) @item
Expand All @@ -113,16 +113,16 @@
(call
method: (identifier) @name
arguments: (argument_list . [
(string) @name
(simple_symbol) @name
(scope_resolution) @name
(constant) @name
(string) @context.extra
(simple_symbol) @context.extra
(scope_resolution) @context.extra
(constant) @context.extra
"," @context
]* [
(string) @name
(simple_symbol) @name
(scope_resolution) @name
(constant) @name
(string) @context.extra
(simple_symbol) @context.extra
(scope_resolution) @context.extra
(constant) @context.extra
]
)
) @item
Expand Down