Fix label_for_symbol - #78
Merged
Merged
Conversation
fix-label_for_symbol
…label_for_symbol fix-label_for_symbol
|
We require contributors to sign our Contributor License Agreement, and we don't have @roanutil on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
requested changes
Jul 20, 2026
MrSubidubi
left a comment
MrSubidubi
left a comment
Contributor
There was a problem hiding this comment.
Thank you and sorry for the slow response!
This overall looks good, my only concern would be the fixture files - can we remove those?
fix-label_for_symbol
Contributor
Author
Fixture removed. Thanks for making time to review this. |
MrSubidubi
approved these changes
Jul 20, 2026
MrSubidubi
enabled auto-merge (squash)
July 20, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
label_for_symbolfunction does not handle some symbol types that SourtKit-LSP supports. Further, theCodeLabel.filter_rangeused is not always sensible.I've adde a fixture swift package for easy comparison of the extension's behavior. However, I understand if that isn't something maintainers would want merged.
The most obvious visual difference after these changes is when searching for symbols while
semantic_tokensis set tofullfor swift. The top screenshot is with these changes installed as a dev extension. The bottom screenshot is the current published version of the extension.