Supporting running nested SPM tests - #81
Merged
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @kamaal111 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
**Issue** Fixes zed-extensions#13 **Issue before this change** When working in a folder where the root folder is not a SPM package, we were getting the following error: ``` error: Could not find Package.swift in this directory or any of its parent directories. ``` This happened because `swift test` was being ran without a package path, so SwiftPM tried to resolve `Package.swift` from the workspace root. **Solution** Add `--package-path $ZED_DIRNAME` to `swift test`. `$ZED_DIRNAME` points to the directory of the test file we are attempting to run. Even when that directory is not the package root, SwiftPM is able to resolve the owning `Package.swift` by traversing upwards to the root of the package. This makes it possible to run tests from nested SPM packages in a folder or workspace that contains one or many separate SPM packages. **Testing instructions** ```sh mkdir testing-this cd testing-this swift package init --package-path Nested zed . ``` If you run the tests before this change then you will see the error above. With this fix applied, the tests can be ran successfully. Signed-off-by: Kamaal Farah <kamaal.f1@gmail.com>
MrSubidubi
approved these changes
Jul 20, 2026
MrSubidubi
left a comment
MrSubidubi
left a comment
Contributor
There was a problem hiding this comment.
Very nice, thank you! And congratulations to your first contribution! 🎉
MrSubidubi
enabled auto-merge (squash)
July 20, 2026 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #13
Issue before this change
When working in a folder where the root folder is not a SPM package, we were getting the following error:
This happened because
swift testwas being ran without a package path, so SwiftPM tried to resolvePackage.swiftfrom the workspace root.Solution
Add
--package-path $ZED_DIRNAMEtoswift test.$ZED_DIRNAMEpoints to the directory of the test file we are attempting to run. Even when that directory is not the package root, SwiftPM is able to resolve the owningPackage.swiftby traversing upwards to the root of the package.This makes it possible to run tests from nested SPM packages in a folder or workspace that contains one or many separate SPM packages.
Testing instructions
If you run the tests before this change then you will see the error above. With this fix applied, the tests can be ran successfully.