Skip to content

Revert "Pin vue-language-server to v3.2.1 to avoid upstream crash (#107)" #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrSubidubi merged 1 commit into from
May 15, 2026
+1 −7
Merged

Revert "Pin vue-language-server to v3.2.1 to avoid upstream crash (#107)" #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/vue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ use zed_extension_api::{self as zed, serde_json, Result};
const SERVER_PATH: &str = "node_modules/@vue/language-server/bin/vue-language-server.js";
const PACKAGE_NAME: &str = "@vue/language-server";

// Pin to 3.2.1 to work around an upstream crash in @vue/language-service where
// `meta?.props.map(...)` throws when `meta.props` is undefined.
// See: https://github.com/vuejs/language-tools/issues/5956
// TODO: Remove this pin once upstream publishes a fixed version.
const PINNED_SERVER_VERSION: &str = "3.2.1";

const TYPESCRIPT_PACKAGE_NAME: &str = "typescript";
const TS_PLUGIN_PACKAGE_NAME: &str = "@vue/typescript-plugin";

Expand Down Expand Up @@ -54,7 +48,7 @@ impl VueExtension {
language_server_id,
&zed::LanguageServerInstallationStatus::CheckingForUpdate,
);
let version = PINNED_SERVER_VERSION.to_string();
let version = zed::npm_package_latest_version(PACKAGE_NAME)?;

if !server_exists
|| zed::npm_package_installed_version(PACKAGE_NAME)?.as_ref() != Some(&version)
Expand Down