Skip to content

blade: Update to e142a3a to fix crash#17510

Merged
jvmncs merged 1 commit into
zed-industries:mainfrom
apricotbucket28:wayland-vulkan-crash
Sep 6, 2024
Merged

blade: Update to e142a3a to fix crash#17510
jvmncs merged 1 commit into
zed-industries:mainfrom
apricotbucket28:wayland-vulkan-crash

Conversation

@apricotbucket28

@apricotbucket28 apricotbucket28 commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Closes #17005

Like #17319, but based on kvark/blade#144.

This should be cherry-picked into preview if possible 🙂

Release Notes:

  • Linux: Fixed crash when closing windows on Wayland.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Sep 6, 2024
@zed-industries-bot

Copy link
Copy Markdown
Contributor
Messages
📖

This PR includes links to the following GitHub Issues: #17005
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against e50f84b

@jvmncs

jvmncs commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

hm, these blade revisions not being on its main are breaking the flake builds at nix/build.nix. that's more due to an idiosyncrasy of crane (nix project used there) rather than anything in this work.

I've been meaning to figure out a fix for that, but any idea when these revisions will land on blade main?

@apricotbucket28

Copy link
Copy Markdown
Contributor Author

hm, these blade revisions not being on its main are breaking the flake builds at nix/build.nix. that's more due to an idiosyncrasy of crane (nix project used there) rather than anything in this work.

I've been meaning to figure out a fix for that, but any idea when these revisions will land on blade main?

Hmm, the master/preview branches are currently running this revision of Blade to fix some issues on Intel + Nvidia systems. According to #17022 (comment) it seems to be working fine so far, so hopefully it won't be long until those changes are merged.

@jvmncs

jvmncs commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

yeah, I believe the nix builds broke for commits after #17022. luckily I don't think many people besides me use the flake build for themselves yet, just the devShell, which is unaffected. thanks!

@jvmncs jvmncs merged commit f91bf7f into zed-industries:main Sep 6, 2024
@apricotbucket28 apricotbucket28 deleted the wayland-vulkan-crash branch September 6, 2024 20:00
notpeter pushed a commit that referenced this pull request Sep 6, 2024
Closes #17005

Like #17319, but based on
kvark/blade#144.

This should be cherry-picked into preview if possible 🙂 

Release Notes:

- Linux: Fixed crash when closing windows on Wayland.
@notpeter

notpeter commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

I've kicked off the preview build and will publish the release (v0.152.2-pre) when it finishes.
Thanks @apricotbucket28

@potchin

potchin commented Sep 9, 2024

Copy link
Copy Markdown

Any idea when this is likely to hit the preview channel?

@notpeter

notpeter commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

Our Linux Arm Github Actions runner was deprecated (running Ubuntu 20.04 to get an old LibC) and is no longer available. This prevented the release from finalizing. We may have to manually build for Linux on arm for a while until we get it going again with a newer runner. Fix here:

Apologies for the delay. We have been distracted by travel and prep for RustConf.

@notpeter

Copy link
Copy Markdown
Contributor

This is now out in Zed Preview v0.152.3.

@potchin

potchin commented Sep 10, 2024

Copy link
Copy Markdown

Prefect, confirmed fixed for me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closing a window crashes other Zed windows

5 participants