Feature/ci workflow - #65
Merged
Merged
Conversation
The repo uses single quotes, no semicolons, and no arrow-paren wrappers, but biome.json configured double quotes and relied on defaults that fought the existing style, producing ~53 format disagreements. - biome.json: quoteStyle single, semicolons asNeeded, arrowParentheses asNeeded; fix $schema URL to match installed Biome 2.4.6 - Apply biome check --write across 27 files (cosmetic only: line collapsing, quote/semicolon normalization; no semantic changes) - package.json: upgrade check/lint scripts from biome lint to biome check so CI can enforce formatting + import sorting alongside lint bun run check and bun run build both pass; bundle output byte-identical.
The repo had no CI; the only workflow (npm-publish.yml) published to npm
on GitHub release without running any tests, so a broken branch could
ship a release with provenance attached.
- ci.yml: two jobs on push/PR to main and next
- test (required): typecheck, biome check, unit tests, bundle-size
regression, build
- performance (continue-on-error): timing regression, informational
only since shared runners are too noisy for assertions
- npm-publish.yml: run bun run check (typecheck + biome check + tests +
bundle regression) before Build package
Both jobs use frozen-lockfile installs so PRs can't silently change
dependencies. After merge, mark the test job as a required status check
in GitHub branch protection for main and next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.