STA-31: remove incompatible walletconnect logger override and enforce Yarn 4 on Vercel - #54
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@walletconnect/loggerresolution override frompackage.json.yarn.lockso@walletconnect/logger@2.1.2is resolved where requested.vercel.jsoninstall command to enforce Corepack + Yarn 4 install path on Vercel.Validation
yarn install(Yarn 4.12.0) no longer shows the incompatible resolution warning:Resolution field "@walletconnect/logger@3.0.0" is incompatible with requested version "@walletconnect/logger@2.1.2".yarn checkcurrently fails on pre-existing TypeScript errors insrc/app/(app)/dashboard/setup/components/setup-wizard.tsxfrommainbaseline (unrelated to this diff).vercel buildin this fresh worktree requires project settings pull first (vercel pull --yes), so preview validation is expected via PR deployment.Linear
Greptile Summary
Fixed incompatible WalletConnect logger resolution and enforced Yarn 4 runtime on Vercel. The PR removes the forced
@walletconnect/logger@3.0.0override that was causing version conflicts with dependencies requesting 2.1.2, regenerates the lockfile to properly resolve 2.1.2, and adds avercel.jsonconfig to ensure Vercel uses Corepack + Yarn 4.12.0 during deployments.Key Changes:
@walletconnect/logger@3.0.0from resolutions inpackage.json- this was overriding transitive dependencies that specifically require 2.1.2vercel.jsonwith custom install command using Corepack to activate Yarn 4.12.0 and--immutableflag for lockfile validationyarn.locknow includes the proper@walletconnect/logger@2.1.2entry with its dependencies (@walletconnect/safe-json@^1.0.2,pino@7.11.0)Validation Notes:
The PR description mentions that
yarn checkfails on pre-existing TypeScript errors insetup-wizard.tsxfrom the main branch, which is unrelated to this change. Preview validation is expected via Vercel PR deployment.Confidence Score: 5/5
Important Files Changed
@walletconnect/logger@3.0.0resolution override that was forcing version 3.0.0 when dependencies require 2.1.2@walletconnect/logger@2.1.2resolution, removing the incompatibility warningLast reviewed commit: ff831f4